You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2009/01/12 17:36:06 UTC
[jira] Created: (JCR-1933) Session.isLive() and logout() throw
exceptions
Session.isLive() and logout() throw exceptions
----------------------------------------------
Key: JCR-1933
URL: https://issues.apache.org/jira/browse/JCR-1933
Project: Jackrabbit
Issue Type: Bug
Components: jackrabbit-jcr-rmi
Affects Versions: 1.5.0
Reporter: Marcel Reutegger
Priority: Minor
The two methods will throw an exception in case the remote session is not available anymore. For most other methods an exception is OK in that case, but I think for the methods isLive() and logout() (both do not declare any exception) a client expects a different behavior. I propose we change it as follows:
- Session.isLive(): return false if remote session is not available anymore
- Session.logout(): write a log message, but do not throw a runtime exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCRRMI-3) Session.isLive() and logout() throw
exceptions
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCRRMI-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCRRMI-3.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.0
Assignee: Jukka Zitting
Fixed in revision 747337.
> Session.isLive() and logout() throw exceptions
> ----------------------------------------------
>
> Key: JCRRMI-3
> URL: https://issues.apache.org/jira/browse/JCRRMI-3
> Project: Jackrabbit JCR-RMI
> Issue Type: Bug
> Reporter: Marcel Reutegger
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.0
>
>
> The two methods will throw an exception in case the remote session is not available anymore. For most other methods an exception is OK in that case, but I think for the methods isLive() and logout() (both do not declare any exception) a client expects a different behavior. I propose we change it as follows:
> - Session.isLive(): return false if remote session is not available anymore
> - Session.logout(): write a log message, but do not throw a runtime exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JCRRMI-3) Session.isLive() and
logout() throw exceptions
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCRRMI-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663324#action_12663324 ]
fmeschbe edited comment on JCRRMI-3 at 1/13/09 5:11 AM:
-----------------------------------------------------------------
+1
with remark: The exception thrown is a RuntimeException, which would be nice to have documented in JavaDoc, but which should declared in a throws clause on the signature.
So the current behaviour is not technically wrong, just not nice ;-)
was (Author: fmeschbe):
+1
with remark: The exception thrown is a RuntimeException, which would be nice to have documented in JavaDoc, but which should declared in a throws clause on the signature.
> Session.isLive() and logout() throw exceptions
> ----------------------------------------------
>
> Key: JCRRMI-3
> URL: https://issues.apache.org/jira/browse/JCRRMI-3
> Project: Jackrabbit JCR-RMI
> Issue Type: Bug
> Reporter: Marcel Reutegger
> Priority: Minor
>
> The two methods will throw an exception in case the remote session is not available anymore. For most other methods an exception is OK in that case, but I think for the methods isLive() and logout() (both do not declare any exception) a client expects a different behavior. I propose we change it as follows:
> - Session.isLive(): return false if remote session is not available anymore
> - Session.logout(): write a log message, but do not throw a runtime exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1933) Session.isLive() and logout() throw
exceptions
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663029#action_12663029 ]
Alexander Klimetschek commented on JCR-1933:
--------------------------------------------
> - Session.isLive(): return false if remote session is not available anymore
> - Session.logout(): write a log message, but do not throw a runtime exception.
+1
> Session.isLive() and logout() throw exceptions
> ----------------------------------------------
>
> Key: JCR-1933
> URL: https://issues.apache.org/jira/browse/JCR-1933
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-jcr-rmi
> Affects Versions: 1.5.0
> Reporter: Marcel Reutegger
> Priority: Minor
>
> The two methods will throw an exception in case the remote session is not available anymore. For most other methods an exception is OK in that case, but I think for the methods isLive() and logout() (both do not declare any exception) a client expects a different behavior. I propose we change it as follows:
> - Session.isLive(): return false if remote session is not available anymore
> - Session.logout(): write a log message, but do not throw a runtime exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Moved: (JCRRMI-3) Session.isLive() and logout() throw
exceptions
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCRRMI-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting moved JCR-1933 to JCRRMI-3:
-----------------------------------------
Component/s: (was: jackrabbit-jcr-rmi)
Affects Version/s: (was: 1.5.0)
Workflow: no-reopen-closed, patch-avail (was: jira)
Key: JCRRMI-3 (was: JCR-1933)
Project: Jackrabbit JCR-RMI (was: Jackrabbit)
> Session.isLive() and logout() throw exceptions
> ----------------------------------------------
>
> Key: JCRRMI-3
> URL: https://issues.apache.org/jira/browse/JCRRMI-3
> Project: Jackrabbit JCR-RMI
> Issue Type: Bug
> Reporter: Marcel Reutegger
> Priority: Minor
>
> The two methods will throw an exception in case the remote session is not available anymore. For most other methods an exception is OK in that case, but I think for the methods isLive() and logout() (both do not declare any exception) a client expects a different behavior. I propose we change it as follows:
> - Session.isLive(): return false if remote session is not available anymore
> - Session.logout(): write a log message, but do not throw a runtime exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCRRMI-3) Session.isLive() and logout() throw
exceptions
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCRRMI-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663324#action_12663324 ]
Felix Meschberger commented on JCRRMI-3:
----------------------------------------
+1
with remark: The exception thrown is a RuntimeException, which would be nice to have documented in JavaDoc, but which should declared in a throws clause on the signature.
> Session.isLive() and logout() throw exceptions
> ----------------------------------------------
>
> Key: JCRRMI-3
> URL: https://issues.apache.org/jira/browse/JCRRMI-3
> Project: Jackrabbit JCR-RMI
> Issue Type: Bug
> Reporter: Marcel Reutegger
> Priority: Minor
>
> The two methods will throw an exception in case the remote session is not available anymore. For most other methods an exception is OK in that case, but I think for the methods isLive() and logout() (both do not declare any exception) a client expects a different behavior. I propose we change it as follows:
> - Session.isLive(): return false if remote session is not available anymore
> - Session.logout(): write a log message, but do not throw a runtime exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.