You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/12 00:44:05 UTC

[kudu-CR] dist test: enable sharding on more long tests

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4377

to review the following change.

Change subject: dist_test: enable sharding on more long tests
......................................................................

dist_test: enable sharding on more long tests

This enables dist-test sharding for some more of the longest-running
tests.

Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
---
M build-support/dist_test.py
1 file changed, 13 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4377/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: dist_test: enable sharding on more long tests
......................................................................


dist_test: enable sharding on more long tests

This enables dist-test sharding for some more of the longest-running
tests.

Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Reviewed-on: http://gerrit.cloudera.org:8080/4377
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/dist_test.py
1 file changed, 13 insertions(+), 11 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: dist_test: enable sharding on more long tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4377/2/build-support/dist_test.py
File build-support/dist_test.py:

PS2, Line 88:   'raft_consensus-itest': 8,
            :   'cfile-test': 4,
            :   'mt-tablet-test': 4,
            :   'flex_partitioning-itest': 8,
            :   'client-test': 8,
            :   'delete_table-test': 8
Maybe sort alphabetically so it's easier to look up a particular test by name? Obviously not an issue now, but it'll help if the map grows larger.


-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4377

to look at the new patch set (#3).

Change subject: dist_test: enable sharding on more long tests
......................................................................

dist_test: enable sharding on more long tests

This enables dist-test sharding for some more of the longest-running
tests.

Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
---
M build-support/dist_test.py
1 file changed, 13 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4377/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: dist_test: enable sharding on more long tests
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4377

to look at the new patch set (#2).

Change subject: dist_test: enable sharding on more long tests
......................................................................

dist_test: enable sharding on more long tests

This enables dist-test sharding for some more of the longest-running
tests.

Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
---
M build-support/dist_test.py
1 file changed, 13 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4377/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: dist_test: enable sharding on more long tests
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3361/

-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: dist_test: enable sharding on more long tests
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3360/

-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] dist test: enable sharding on more long tests

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: dist_test: enable sharding on more long tests
......................................................................


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3373/

-- 
To view, visit http://gerrit.cloudera.org:8080/4377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b860d584203c1b9b1ad472f620fe06c03eaaa21
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No