You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Alex Van Boxel (Jira)" <ji...@apache.org> on 2020/02/21 12:01:00 UTC

[jira] [Resolved] (BEAM-9241) Fix inconsistent nullability mapping for Protobuf to Schema

     [ https://issues.apache.org/jira/browse/BEAM-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Van Boxel resolved BEAM-9241.
----------------------------------
    Resolution: Fixed

> Fix inconsistent nullability mapping for Protobuf to Schema
> -----------------------------------------------------------
>
>                 Key: BEAM-9241
>                 URL: https://issues.apache.org/jira/browse/BEAM-9241
>             Project: Beam
>          Issue Type: Bug
>          Components: extensions-java-protobuf
>    Affects Versions: 2.18.0
>            Reporter: Alex Van Boxel
>            Assignee: Alex Van Boxel
>            Priority: Major
>             Fix For: 2.20.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Fix the nullability issues with protobuf to schema mapping
>  * Proto3 primitive types should be *not* nullable.
>  * Proto2 required types should be *not* nullable.
>  * Proto2 optional should also be *not* nullable as having an optional value doesn't mean it has not value. The spec states it has the optional value.
>  * Arrays should be *not* nullable, as proto arrays always have an empty array when no value is set.
>  * Maps should be *not* nullable, as proto maps always have an empty map when no value is set.
>  * Elements in an array should be *not* nullable, as nulls are not allowed in an array.
>  * Names and Values should be *not* nullable, as nulls are not allowed.
>  * Rows are nullable, as messages are nullable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)