You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/05 19:59:43 UTC
Review Request 33853: Incorrect behavior for clone and edit widget
wizard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33853/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-10938
https://issues.apache.org/jira/browse/AMBARI-10938
Repository: ambari
Description
-------
1. Cloning a widget should create a user scope cloned widget
2. Editing a shared widget should retain original author of the widget
3. 0 should be a valid value for a warning threshold
4. On checking "show only my widgets" options on widget browser, only user scope widgets of the currently logged in user should be shown.
Diffs
-----
ambari-web/app/controllers/main/service/widgets/create/step3_controller.js 39f3433
ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js edb1b13
ambari-web/app/controllers/main/service/widgets/edit_controller.js 8f66c21
ambari-web/app/mixins/common/widgets/widget_mixin.js 4bace6b
ambari-web/app/models/widget_property.js a2bdda9
ambari-web/app/routes/main.js c0a7082
ambari-web/app/utils/ajax/ajax.js 8cdc12e
Diff: https://reviews.apache.org/r/33853/diff/
Testing
-------
tested patch on a cluster
verified all unit tests passes with the patch
Thanks,
Jaimin Jetly
Re: Review Request 33853: Incorrect behavior for clone and edit
widget wizard
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33853/#review82552
-----------------------------------------------------------
Ship it!
Ship It!
- Xi Wang
On May 5, 2015, 10:59 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33853/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 10:59 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-10938
> https://issues.apache.org/jira/browse/AMBARI-10938
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Cloning a widget should create a user scope cloned widget
> 2. Editing a shared widget should retain original author of the widget
> 3. 0 should be a valid value for a warning threshold
> 4. On checking "show only my widgets" options on widget browser, only user scope widgets of the currently logged in user should be shown.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/step3_controller.js 39f3433
> ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js edb1b13
> ambari-web/app/controllers/main/service/widgets/edit_controller.js 8f66c21
> ambari-web/app/mixins/common/widgets/widget_mixin.js 4bace6b
> ambari-web/app/models/widget_property.js a2bdda9
> ambari-web/app/routes/main.js c0a7082
> ambari-web/app/utils/ajax/ajax.js 8cdc12e
>
> Diff: https://reviews.apache.org/r/33853/diff/
>
>
> Testing
> -------
>
> tested patch on a cluster
> verified all unit tests passes with the patch
>
>
> Thanks,
>
> Jaimin Jetly
>
>