You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/04/06 17:10:25 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #674: ORC-777: Make the vectorized row batch size configurable in MR record readers and writers

dongjoon-hyun commented on a change in pull request #674:
URL: https://github.com/apache/orc/pull/674#discussion_r608034069



##########
File path: java/mapreduce/src/java/org/apache/orc/mapred/OrcMapredRecordReader.java
##########
@@ -69,14 +69,19 @@ public OrcMapredRecordReader(RecordReader reader,
   }
 
   protected OrcMapredRecordReader(Reader fileReader,
-                                  Reader.Options options) throws IOException {
+      Reader.Options options) throws IOException {

Review comment:
       Could you keep the original style here? This looks inconsistent with the other existing one at line 64 and with your new code at line 77.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org