You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/23 02:18:00 UTC
[jira] [Commented] (CALCITE-2587) Avatica - Regenerate protobuf
files for 3.6.1
[ https://issues.apache.org/jira/browse/CALCITE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624901#comment-16624901 ]
ASF GitHub Bot commented on CALCITE-2587:
-----------------------------------------
GitHub user risdenk opened a pull request:
https://github.com/apache/calcite-avatica/pull/73
[CALCITE-2587] Regenerate protobuf files for 3.6.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/risdenk/calcite-avatica CALCITE-2587
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit f7b8ed6f92c02a75f554f71a25ff94d803967d83
Author: Kevin Risden <kr...@...>
Date: 2018-09-23T02:16:03Z
[CALCITE-2587] Regenerate protobuf files for 3.6.1
Signed-off-by: Kevin Risden <kr...@apache.org>
----
> Avatica - Regenerate protobuf files for 3.6.1
> ---------------------------------------------
>
> Key: CALCITE-2587
> URL: https://issues.apache.org/jira/browse/CALCITE-2587
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: avatica-1.13.0
>
>
> I was looking into deprecation warnings and found that protobuf 3.6.0 should have added suppresswarnings to a few valueOf calls that were deprecated. However, the java files were not being regenerated even with the protobuf-maven-plugin.
> It seems like the [checkStaleness|https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html#checkStaleness] flag was preventing the compilation even after updating protobuf from 3.5.x to 3.6.1.
> It doesn't look like there is a good reason to have checkStaleness set to true since the protobuf compilation is pretty quick. This should help us catch protobuf errors sooner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)