You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "thomasrebele (via GitHub)" <gi...@apache.org> on 2026/06/09 09:19:27 UTC
[PR] Prepare links for link validation [hive-site]
thomasrebele opened a new pull request, #110:
URL: https://github.com/apache/hive-site/pull/110
Use `{{% ref "..." %}}` instead of `{{< ref "..." >}}`, so that a future link validator will get the link before it is passed to Goldmark. The Goldmark renderer will replace the URL with a shortcode that cannot be validated anymore. (See https://discourse.gohugo.io/t/using-shortcode-inside-render-hook/42038/5).
The modifications have been done with the following command:
```
perl -0pi -e 's/\{\{< ref "([^"]*)" >\}\}/{{% ref "\1" %}}/gm' **/*.md
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] Prepare links for link validation [hive-site]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on PR #110:
URL: https://github.com/apache/hive-site/pull/110#issuecomment-4979309479
Thanks for checking. I guess it makes sense to include `relref` links as well. I've updated the PR, and the perl command in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] Prepare links for link validation [hive-site]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on PR #110:
URL: https://github.com/apache/hive-site/pull/110#issuecomment-5356013596
I executed the perl command on the latest main branch and updated the PR to fix some conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] Prepare links for link validation [hive-site]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on PR #110:
URL: https://github.com/apache/hive-site/pull/110#issuecomment-4979150347
Just to double-check: there are 3 instances of `{{< relref "…" >}}`, which were not considered by this patch:
- content/docs/latest/admin/iceberg-rest-catalog.md:28 ==> [Apache Hive : Setting Up OAuth 2]({{< relref "oauth2/_index.md" >}})
- content/docs/latest/admin/iceberg-rest-catalog.md:44 ==> [Apache Hive : LanguageManual Authorization]({{< relref "../language/languagemanual-authorization.md" >}})
- content/docs/latest/admin/oauth2/_index.md:16 ==> [Keycloak]({{< relref "keycloak.md" >}})
Are these intentionally excluded? Or should the also be change into `{{% relref "…" %}}` for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org