[GitHub] [incubator-druid] jihoonson commented on issue #8112: removed hard-coded Kafka key and value deserializer

[GitBox <gi...@apache.org>]

jihoonson commented on issue #8112: removed hard-coded Kafka key and value deserializer
URL: https://github.com/apache/incubator-druid/pull/8112#issuecomment-514421963
 
 
   @abossert to me, it looks easier to add unit tests to `KafkaRecordSupplierTest`. I guess perhaps you could parameterize that class to test both byte array serde and a simple custom serde. This custom serde doesn't have to be the one you're using. It can be any custom serde. Alternatively, you can add a new test class to only verify that the custom serde works with `KafkaRecordSupplier`. 
   
   I prefer the former one because we can test both default and custom serdes in a single place. But, if it's not feasible or too complex, then I'm ok with adding a new test class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org