You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2008/11/25 20:37:37 UTC
Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
jleroux@apache.org wrote:
> ==============================================================================
> --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy (original)
> +++ ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy Mon Nov 24 02:43:39 2008
> @@ -33,7 +33,7 @@
> if ("search".equals(parameters.findType)) {
> artifactInfoSet = aif.getAllArtifactInfosByNamePartial(name, type);
> if (artifactInfoSet.size() == 1) {
> - artifactInfo = artifactInfoSet[0];
> + artifactInfo = artifactInfoSet.head();
> context.artifactInfo = artifactInfo;
NONONO. Bad.
The api for this returns a java.util.Set. *Only* use methods that are
available on Set(or Collection). Do not depend on any particular
implementation.
Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Bruno,
Actually I was the 1st who spoke about it on this ML and I use it when needed.
It's just that Adam's list is quicker to look at recent commits. Anyway not a big deal my email client is fast enough with my new
machine :o)
Jacques
From: "Bruno Busco" <br...@gmail.com>
> Hi Jacques,
> never used http://fisheye6.atlassian.com/browse/ofbiz/trunk ?
>
> -Bruno
>
> 2008/11/26 Jacques Le Roux <ja...@les7arts.com>
>
>> Hi Adam,
>>
>> I used to look into my email client svn folder. I would switch to your link
>> : clearer, faster and annotated, the only thing I miss is the ability to
>> search *into* commits, not only titles. Is there a mean to do that ?
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Adam Heath" <do...@brainfood.com>
>> To: <de...@ofbiz.apache.org>
>> Sent: Wednesday, November 26, 2008 1:35 AM
>> Subject: Re: svn commit: r720158 -
>> /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
>>
>>
>>
>> Jacques Le Roux wrote:
>>>
>>>> Don't worry Adam, I already reverted in r720161
>>>>
>>>> Thanks for your awareness :o)
>>>>
>>>
>>> Ok, cool. I was looking at my mercurial mirror(1) of ofbiz, saw this
>>> change, then sent the email. Didn't see the later commit.
>>>
>>> ps: (1) is updated every 30 minutes from svn.
>>>
>>> 1: http://hg.webslinger.org/hg/ofbiz.apache.org
>>>
>>>
>>
>
Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
Posted by Bruno Busco <br...@gmail.com>.
Hi Jacques,
never used http://fisheye6.atlassian.com/browse/ofbiz/trunk ?
-Bruno
2008/11/26 Jacques Le Roux <ja...@les7arts.com>
> Hi Adam,
>
> I used to look into my email client svn folder. I would switch to your link
> : clearer, faster and annotated, the only thing I miss is the ability to
> search *into* commits, not only titles. Is there a mean to do that ?
>
> Thanks
>
> Jacques
>
> From: "Adam Heath" <do...@brainfood.com>
> To: <de...@ofbiz.apache.org>
> Sent: Wednesday, November 26, 2008 1:35 AM
> Subject: Re: svn commit: r720158 -
> /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
>
>
>
> Jacques Le Roux wrote:
>>
>>> Don't worry Adam, I already reverted in r720161
>>>
>>> Thanks for your awareness :o)
>>>
>>
>> Ok, cool. I was looking at my mercurial mirror(1) of ofbiz, saw this
>> change, then sent the email. Didn't see the later commit.
>>
>> ps: (1) is updated every 30 minutes from svn.
>>
>> 1: http://hg.webslinger.org/hg/ofbiz.apache.org
>>
>>
>
Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
Posted by Adam Heath <do...@brainfood.com>.
Jacques Le Roux wrote:
> Hi Adam,
>
> I used to look into my email client svn folder. I would switch to your
> link : clearer, faster and annotated, the only thing I miss is the
> ability to search *into* commits, not only titles. Is there a mean to do
> that ?
We are still new to mercurial; only been using it for 3-4 months. Need
to look at other software. That link that I sent is the standard hgweb
setup.
Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Adam,
I used to look into my email client svn folder. I would switch to your link : clearer, faster and annotated, the only thing I miss
is the ability to search *into* commits, not only titles. Is there a mean to do that ?
Thanks
Jacques
From: "Adam Heath" <do...@brainfood.com>
To: <de...@ofbiz.apache.org>
Sent: Wednesday, November 26, 2008 1:35 AM
Subject: Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
> Jacques Le Roux wrote:
>> Don't worry Adam, I already reverted in r720161
>>
>> Thanks for your awareness :o)
>
> Ok, cool. I was looking at my mercurial mirror(1) of ofbiz, saw this
> change, then sent the email. Didn't see the later commit.
>
> ps: (1) is updated every 30 minutes from svn.
>
> 1: http://hg.webslinger.org/hg/ofbiz.apache.org
>
Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
Posted by Adam Heath <do...@brainfood.com>.
Jacques Le Roux wrote:
> Don't worry Adam, I already reverted in r720161
>
> Thanks for your awareness :o)
Ok, cool. I was looking at my mercurial mirror(1) of ofbiz, saw this
change, then sent the email. Didn't see the later commit.
ps: (1) is updated every 30 minutes from svn.
1: http://hg.webslinger.org/hg/ofbiz.apache.org
Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
Don't worry Adam, I already reverted in r720161
Thanks for your awareness :o)
Jacques
From: "Adam Heath" <do...@brainfood.com>
> jleroux@apache.org wrote:
>> ==============================================================================
>> --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy (original)
>> +++ ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy Mon Nov 24 02:43:39 2008
>> @@ -33,7 +33,7 @@
>> if ("search".equals(parameters.findType)) {
>> artifactInfoSet = aif.getAllArtifactInfosByNamePartial(name, type);
>> if (artifactInfoSet.size() == 1) {
>> - artifactInfo = artifactInfoSet[0];
>> + artifactInfo = artifactInfoSet.head();
>> context.artifactInfo = artifactInfo;
>
> NONONO. Bad.
>
> The api for this returns a java.util.Set. *Only* use methods that are
> available on Set(or Collection). Do not depend on any particular
> implementation.
>
>