You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/11/26 22:15:41 UTC
[jira] [Commented] (FLUME-820) JDBC channel should support capacity
specification.
[ https://issues.apache.org/jira/browse/FLUME-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157610#comment-13157610 ]
jiraposter@reviews.apache.org commented on FLUME-820:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2937/
-----------------------------------------------------------
Review request for Flume and Prasad Mujumdar.
Summary
-------
Added support for specifying the capacity of the JDBC channel. If a non-zero positive value is specified, the channel enforces it as the limit on total number of events persisted at any time. If a zero/negative/unspecified value is provided, the channel operates without any limit. Added a test case as well to exercise this functionality.
Another change that I am sliding in is reducing the overall number of events that tests exercise - from about 2000 to close to 200. This will greatly reduce the amount of time the tests take when running on the JDBC channel module. The test functionality remains the same.
This addresses bug FLUME-820.
https://issues.apache.org/jira/browse/FLUME-820
Diffs
-----
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 7e0b3ac
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 7b29c7d
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java c1bc400
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1065ef9
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 68946c9
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/MockEventUtils.java 78eda51
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 9ce6d16
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 4c3012d
Diff: https://reviews.apache.org/r/2937/diff
Testing
-------
Ran all JDBC channel tests.
Thanks,
Arvind
> JDBC channel should support capacity specification.
> ---------------------------------------------------
>
> Key: FLUME-820
> URL: https://issues.apache.org/jira/browse/FLUME-820
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-820-1.patch
>
>
> users should be able to specify capacity for the JDBC channel in terms of total number of events stored. This will help ensure that the channel does not overwhelm the system by occupying the entire available disk space.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira