[GitHub] [avro] perj commented on a diff in pull request #1843: AVRO-3622 (python) Fix compatibility check for schemas having or missing namespace

[GitBox <gi...@apache.org>]

perj commented on code in PR #1843:
URL: https://github.com/apache/avro/pull/1843#discussion_r958322538


##########
lang/py/avro/test/test_compatibility.py:
##########
@@ -659,6 +688,7 @@ def test_schema_compatibility(self):
                 ENUM_ABC_FIELD_DEFAULT_B_ENUM_DEFAULT_A_RECORD,
             ),
             (NS_RECORD1, NS_RECORD2),
+            (WITHOUT_NAMESPACE_RECORD, WITH_NAMESPACE_RECORD),

Review Comment:
   Feel free to ignore this as I'm not too familiar with this code, but are these two really compatible? To me, it reads like one of them has the null namespace and the other one has the namespace "ns". Don't namepaces have to match to be compatible?
   
   I'd expect `{"namespace":"ns","name":"Record"}` to be compatible with `{"name":"ns.Record"}` but not too sure about if that's compatible with `{"name":"Record"}`. But like I said, I'm not an expert on Avro.



##########
lang/py/avro/test/test_schema.py:
##########
@@ -629,6 +641,10 @@ def test_invalid_name(self):
             None,
             None,
         )
+        # A name cannot start with dot."

Review Comment:
   A few lines later, the spec says:
   
   > The null namespace may not be used in a dot-separated sequence of names.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org