You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2016/01/28 11:22:30 UTC
[GitHub] flink pull request: [FLINK-3295][Kafka 0.8] Improve ZK error behav...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1555
[FLINK-3295][Kafka 0.8] Improve ZK error behavior
This PR changes the behavior of the Kafka 0.8 source if there is an error while getting the initial offsets from ZK.
Instead of failing, the exception is only logged (with the ZK connect string) and the offsets are determined from kafka (depending on `auto.offset.reset`).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1555.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1555
----
commit fc59b453f4e4b47ca65d17db3d13d30940b93f1a
Author: Robert Metzger <rm...@apache.org>
Date: 2016-01-28T09:53:13Z
[FLINK-3295][Kafka 0.8] Improve ZK error behavior
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3295][Kafka 0.8] Improve ZK error behav...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1555#issuecomment-176230855
Yes, curator is retrying using an exponential backoff retry.
I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #1555: [FLINK-3295][Kafka 0.8] Improve ZK error behavior
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/1555
Closing this PR. It's outdated by now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3295][Kafka 0.8] Improve ZK error behav...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1555#issuecomment-176175300
I think we have to make this a bit more sophisticated and allow the user to specify behavior when offsets cannot be fetched:
- FAIL (fail if any offset could not be fetched)
- FALLBACK_ALL (as soon as one cannot be fetched, all follow the auto-reset behavior)
- FALLBACK_FAILED (only the ones that could not be fetched follow the auto-reset behavior)
Do we need to implement re-tries, or does the ZooKeeper framework handle that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #1555: [FLINK-3295][Kafka 0.8] Improve ZK error behavior
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/1555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---