You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 05:23:40 UTC

[GitHub] [spark] yaooqinn commented on a change in pull request #28003: [SPARK-31234][SQL] ResetCommand should reset config to sc.conf only

yaooqinn commented on a change in pull request #28003: [SPARK-31234][SQL] ResetCommand should reset config to sc.conf only
URL: https://github.com/apache/spark/pull/28003#discussion_r397615611
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -3258,7 +3258,9 @@ class SQLConf extends Serializable with Logging {
   }
 
   def clear(): Unit = {
 
 Review comment:
   This API is exposed to users, and make the SQLConf hard to restore to its initial state after calling `spark.sessionState.conf.clear`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org