You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 16:01:50 UTC
[GitHub] [superset] kgabryje opened a new pull request #15742: chore(explore): Bump plugin-chart-pivot-table
kgabryje opened a new pull request #15742:
URL: https://github.com/apache/superset/pull/15742
### SUMMARY
Bumps `@superset-ui/plugin-chart-pivot-table` to version `0.17.68`. This change will introduce conditional formatting, d3 formatting of metrics from dataset, date formatting, combining metrics and new expand/collapse icons for pivot table. For details, see https://github.com/apache-superset/superset-ui/pull/1217
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See videos in https://github.com/apache-superset/superset-ui/pull/1217
### TESTING INSTRUCTIONS
Conditional formatting: test behaviour described in https://github.com/apache/superset/pull/15651
D3 formatting for metrics:
1. Open Edit Dataset modal and set custom formatting for some saved metrics
2. Create a pivot table with those metrics
3. Verify that formatting from dataset has been applied
4. Verify that formatting from dataset overrides formatting defined in Customize tab
Date formatting:
1. Create a pivot table, use temporal columns as row or column groups
2. Verify that date formatting selected in Customize tab is applied correctly
Combining metrics:
1. Create a pivot table and check "Combine metrics" checkbox
2. Verify that now metrics are used as the lowest level group rather than highest
3. Verify that the feature works with Transpose pivot and applying metrics to rows instead of columns
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15742: chore(explore): Bump plugin-chart-pivot-table
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15742:
URL: https://github.com/apache/superset/pull/15742#issuecomment-881567400
# [Codecov](https://codecov.io/gh/apache/superset/pull/15742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15742](https://codecov.io/gh/apache/superset/pull/15742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88dcfa0) into [master](https://codecov.io/gh/apache/superset/commit/fe68e45f5243c8401c0fc20cdcce67e7ec4ba7f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe68e45) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/15742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15742 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 983 983
Lines 51609 51609
Branches 6988 6988
=======================================
Hits 39696 39696
Misses 11690 11690
Partials 223 223
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.36% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15742?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15742?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe68e45...88dcfa0](https://codecov.io/gh/apache/superset/pull/15742?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #15742: chore(explore): Bump plugin-chart-pivot-table
Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #15742:
URL: https://github.com/apache/superset/pull/15742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org