[GitHub] [commons-net] garydgregory commented on a diff in pull request #157: Net constants refine

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on code in PR #157:
URL: https://github.com/apache/commons-net/pull/157#discussion_r1268661489


##########
src/main/java/org/apache/commons/net/util/NetConstants.java:
##########
@@ -23,7 +23,7 @@
  *
  * @since 3.8.0
  */
-public class NetConstants {
+public final class NetConstants {

Review Comment:
   @jkbkupczyk 
   You can't make this class final as it will break binary compatibility (it is public).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org