[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #4035: work_queue: schedule the work queue using the timer mechanism

[GitBox <gi...@apache.org>]

Donny9 commented on a change in pull request #4035:
URL: https://github.com/apache/incubator-nuttx/pull/4035#discussion_r662703930



##########
File path: sched/wqueue/kwork_queue.c
##########
@@ -148,16 +107,39 @@ static void work_qqueue(FAR struct kwork_wqueue_s *wqueue,
 int work_queue(int qid, FAR struct work_s *work, worker_t worker,
                FAR void *arg, clock_t delay)
 {
+  irqstate_t flags;
+
+  /* Remove the entry from the timer and work queue. */
+
+  work_cancel(qid, work);
+
+  /* Interrupts are disabled so that this logic can be called from with
+   * task logic or ifrom nterrupt handling logic.

Review comment:
       > typo:
   > 
   > `ifrom nterrupt handling logic`
   > 
   > should be
   > 
   > `from interrupt handling logic`
   
   Done. Thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org