You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:39:27 UTC
[GitHub] [superset] pkdotson commented on a change in pull request #17046: fix: dropdown placement for cascading filters popover
pkdotson commented on a change in pull request #17046:
URL: https://github.com/apache/superset/pull/17046#discussion_r729978762
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx
##########
@@ -52,6 +52,7 @@ const CascadeFilterControl: React.FC<CascadeFilterControlProps> = ({
dataMaskSelected={dataMaskSelected}
filter={filter}
directPathToChild={directPathToChild}
+ showOverflow
Review comment:
see below comment
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx
##########
@@ -61,6 +62,7 @@ const CascadeFilterControl: React.FC<CascadeFilterControlProps> = ({
dataMaskSelected={dataMaskSelected}
filter={childFilter}
directPathToChild={directPathToChild}
+ showOverflow
Review comment:
No because we want here as. default always.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx
##########
@@ -61,6 +62,7 @@ const CascadeFilterControl: React.FC<CascadeFilterControlProps> = ({
dataMaskSelected={dataMaskSelected}
filter={childFilter}
directPathToChild={directPathToChild}
+ showOverflow
Review comment:
It is being used. FilterControl component is being used by other components where this prop is not really neccessary. So this say yes it showoverflow prop is true in this instance when in use for the Cascadefiltercontrol.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx
##########
@@ -61,6 +62,7 @@ const CascadeFilterControl: React.FC<CascadeFilterControlProps> = ({
dataMaskSelected={dataMaskSelected}
filter={childFilter}
directPathToChild={directPathToChild}
+ showOverflow
Review comment:
It is being used. FilterControl component is being used by other components where this prop is not really neccessary. Showoverflow prop is true in this instance when in use for the Cascadefiltercontrol.
##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx
##########
@@ -199,7 +199,12 @@ const CascadePopover: React.FC<CascadePopoverProps> = ({
onVisibleChange={onVisibleChange}
placement="rightTop"
id={filter.id}
- overlayStyle={{ width: '400px' }}
+ overlayStyle={{
+ width: '400px',
+ position: 'relative',
+ overflow: 'scroll',
Review comment:
either works but i'll put it to auto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org