You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/07/20 13:38:43 UTC

[GitHub] GabrielBrascher commented on a change in pull request #1730: VMTemplateZone needs some love

GabrielBrascher commented on a change in pull request #1730: VMTemplateZone needs some love
URL: https://github.com/apache/cloudstack/pull/1730#discussion_r204033004
 
 

 ##########
 File path: engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateZoneDaoImpl.java
 ##########
 @@ -55,22 +55,22 @@ public VMTemplateZoneDaoImpl() {
     public List<VMTemplateZoneVO> listByZoneId(long id) {
         SearchCriteria<VMTemplateZoneVO> sc = ZoneSearch.create();
         sc.setParameters("zone_id", id);
-        return listIncludingRemovedBy(sc);
+        return listBy(sc);
     }
 
     @Override
     public List<VMTemplateZoneVO> listByTemplateId(long templateId) {
 
 Review comment:
   The listByTemplateId method is used twice to send alert messages.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services