You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/05/16 21:46:27 UTC
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6904
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Remove redundant libevent flag when building Thrift
--with-libevent was specified twice, and overridden by the second
option. Libevent is not required for Thrift if the non-blocking server
is not used.
Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
---
M source/thrift/build.sh
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/04/6904/1
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6904/1/source/thrift/build.sh
File source/thrift/build.sh:
Line 35
> I don't think we need libevent otherwise, right? If not, please remove from
Done - did it in a separate commit in case we ever want to revert it.
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Remove redundant libevent flag when building Thrift
--with-libevent was specified twice, and overridden by the second
option. Libevent is not required for Thrift if the non-blocking server
is not used.
Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
---
M buildall.sh
M source/thrift/build.sh
2 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Henry Robinson: Verified
Matthew Jacobs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#2).
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Remove redundant libevent flag when building Thrift
--with-libevent was specified twice, and overridden by the second
option. Libevent is not required for Thrift if the non-blocking server
is not used.
Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
---
M buildall.sh
M source/thrift/build.sh
2 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/04/6904/2
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Patch Set 2:
I should have asked earlier - do you know why we stopped needing libevent for thrift?
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Patch Set 1:
Yep - mentioned in the commit msg "Libevent is not required for Thrift if the non-blocking server is not used.". We stopped using the non-blocking server a few years ago.
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6904/1/source/thrift/build.sh
File source/thrift/build.sh:
Line 35
I don't think we need libevent otherwise, right? If not, please remove from buildall.sh and the corresponding source/libevent/*
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] Remove redundant libevent flag when building Thrift
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
......................................................................
Patch Set 2: Verified+1
Passed a full toolchain build.
--
To view, visit http://gerrit.cloudera.org:8080/6904
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6ef921f4389bd875578cd681f008b86f633af8
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No