You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/06/05 23:37:20 UTC
[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes
Hello Dan Burkert, Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7090
to review the following change.
Change subject: build-and-test.sh: only rerun Spark tests if Java build passes
......................................................................
build-and-test.sh: only rerun Spark tests if Java build passes
Otherwise, the output of a failing Spark test from the first build is
overwritten by the second build.
The alternative is to configure Maven to use a different build directory [1]
for the second build, but I think that's more trouble than it's worth.
1. https://stackoverflow.com/questions/3908013/maven-how-to-change-path-to-target-directory-from-command-line
Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
---
M build-support/jenkins/build-and-test.sh
1 file changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7090/1
--
To view, visit http://gerrit.cloudera.org:8080/7090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: build-and-test.sh: only rerun Spark tests if Java build passes
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7090/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
Line 357: # Run the full Maven build (with Spark 1.x).
This is running with Spark 2.x.
Line 366: # this time just to test Spark 2.x with Scala 2.10.
The else branch is running Spark 1.x/Scala 2.10
--
To view, visit http://gerrit.cloudera.org:8080/7090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: build-and-test.sh: only rerun Spark tests if Java build passes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7090/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
Line 366: # this time just to test Spark 2.x with Scala 2.10.
> The else branch is running Spark 1.x/Scala 2.10
I assumed "spark_2.10" meant "Spark version 2.10". But it actually means "Spark 1, Scala version 2.10". Whoops.
--
To view, visit http://gerrit.cloudera.org:8080/7090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: build-and-test.sh: only rerun Spark tests if Java build passes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#2).
Change subject: build-and-test.sh: only rerun Spark tests if Java build passes
......................................................................
build-and-test.sh: only rerun Spark tests if Java build passes
Otherwise, the output of a failing Spark test from the first build is
overwritten by the second build.
The alternative is to configure Maven to use a different build directory [1]
for the second build, but I think that's more trouble than it's worth.
1. https://stackoverflow.com/questions/3908013/maven-how-to-change-path-to-target-directory-from-command-line
Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
---
M build-support/jenkins/build-and-test.sh
1 file changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7090/2
--
To view, visit http://gerrit.cloudera.org:8080/7090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: build-and-test.sh: only rerun Spark tests if Java build passes
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins, unrelated failure in update_scan_delta_compact-test.
--
To view, visit http://gerrit.cloudera.org:8080/7090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: only rerun Spark tests if Java build passes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: build-and-test.sh: only rerun Spark tests if Java build passes
......................................................................
build-and-test.sh: only rerun Spark tests if Java build passes
Otherwise, the output of a failing Spark test from the first build is
overwritten by the second build.
The alternative is to configure Maven to use a different build directory [1]
for the second build, but I think that's more trouble than it's worth.
1. https://stackoverflow.com/questions/3908013/maven-how-to-change-path-to-target-directory-from-command-line
Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Reviewed-on: http://gerrit.cloudera.org:8080/7090
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 13 insertions(+), 7 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief21061be0615ca4d9d8980430f4982c8c43d77c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>