You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2014/09/30 23:15:39 UTC

[GitHub] storm pull request: update supervisor.clj add a comment to supervi...

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/258#discussion_r18247882
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -207,7 +207,7 @@
        :isupervisor isupervisor
        :active (atom true)
        :uptime (uptime-computer)
    -   :worker-thread-pids-atom (atom {})
    +   :worker-thread-pids-atom (atom {}) ;; used for saving jvm thread id when running in local mode
    --- End diff --
    
    It seems this stories UUIDs for each worker when run in local mode.  It might be better to just rename the symbol for clarity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---