You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by vh...@apache.org on 2011/09/12 16:27:26 UTC
svn commit: r1169766 -
/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Author: vhennebert
Date: Mon Sep 12 14:27:25 2011
New Revision: 1169766
URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
Log:
Bugzilla #51790: source file contains non-ascii character
Removed @author tags
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon Sep 12 14:27:25 2011
@@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
/**
* RTF Handler: generates RTF output using the structure events from
* the FO Tree sent to this structure handler.
- *
- * @author Bertrand Delacretaz <bd...@codeconsult.ch>
- * @author Trembicki-Guy, Ed <Gu...@DNB.com>
- * @author Boris Poudérous <bo...@eads-telecom.com>
- * @author Peter Herweg <ph...@web.de>
- * @author Andreas Putz <a....@skynamics.com>
*/
public class RTFHandler extends FOEventHandler {
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
Re: Maintaining the list of contributors
Posted by Simon Pepping <sp...@leverkruid.eu>.
On Wed, Sep 14, 2011 at 02:13:16PM +0200, Jeremias Maerki wrote:
> You're right. I think there's a lot of inconsistency here. So, why not
> keep it VERY simple?
>
> 1. Wipe the team page clean.
> 2. Add a paragraph with a alphabetically sorted, comma-separated list of
> names of contributors (without mail addresses, includes committers). The
> listing would be regardless of the amount of work on FOP. If need be,
> the committers in bold.
> 3. Add a link to
> http://people.apache.org/committers-by-project.html#xmlgraphics-fop
> (which, unfortunately, doesn't contain the list of committers before the
> move from CVS to SVN).
This list only contains the current committers, not past ones. I
prefer the list of inactive committers to stay. Committers are not
just a special type of contributors; they manage FOP's source code
repository.
> 4. Possibly restore the note about FOP's founder.
>
> No more active or inactive contributors/committers (is he still active?
> is he not?...). Every committer makes sure that the names of
Committers are made inactive according to the rules in the project
charter. The PMC Chair applies those rules. I did that during the past
year.
> contributors make it to the contributor list. We know who the candidates
> for committership are from our daily work. I think that would increase
> fairness and maintainability of the team list. And it allows to remove
> all author tags and comments in a fair way. If any committer thinks that
> the amount of recognition for the project is important, we can always
> add a link to the Ohloh page of FOP which does a much better job at
> telling who contributed how much and when.
>
> That an idea?
I like the list of contributors, because subversion and bugzilla do
not easily reveal that information.
Simon
Re: Maintaining the list of contributors [was: svn commit: r1169766
- /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java]
Posted by Vincent Hennebert <vh...@gmail.com>.
On 14/09/11 13:13, Jeremias Maerki wrote:
> You're right. I think there's a lot of inconsistency here. So, why not
> keep it VERY simple?
>
> 1. Wipe the team page clean.
> 2. Add a paragraph with a alphabetically sorted, comma-separated list of
> names of contributors (without mail addresses, includes committers). The
> listing would be regardless of the amount of work on FOP. If need be,
> the committers in bold.
Preceded by a sentence like ‘These are the people who are contributing,
or have contributed, to FOP’? In other words, mixing active and inactive
contributors/committers? Sounds good to me.
> 3. Add a link to
> http://people.apache.org/committers-by-project.html#xmlgraphics-fop
> (which, unfortunately, doesn't contain the list of committers before the
> move from CVS to SVN).
Which IMO would make it unnecessary to put committers in bold in the
list above.
> 4. Possibly restore the note about FOP's founder.
I tend to think that as time goes, this information is becoming less and
less relevant. +0 for restoring it.
> No more active or inactive contributors/committers (is he still active?
> is he not?...). Every committer makes sure that the names of
> contributors make it to the contributor list. We know who the candidates
> for committership are from our daily work. I think that would increase
> fairness and maintainability of the team list. And it allows to remove
> all author tags and comments in a fair way. If any committer thinks that
> the amount of recognition for the project is important, we can always
> add a link to the Ohloh page of FOP which does a much better job at
> telling who contributed how much and when.
>
> That an idea?
An idea that I very much like.
+1 from me.
Thanks,
Vincent
> On 14.09.2011 12:12:25 Vincent Hennebert wrote:
>> On 14/09/11 07:54, Jeremias Maerki wrote:
>>> +1 in general on removing author tags (it's a board recommendation after
>>> all). But strong -1 on removing them without adding them to some central
>>> list of contributors.
>>
>> Makes sense, although there’s something I’m not too sure about.
>>
>> Those of the contributors who were committers are already listed in the
>> website’s team page. Regarding the other ones, we could add a ‘Past
>> Contributors’ section to that page.
>>
>> However, current contributors who submit a patch on a one-off basis,
>> therefore will never become committers, will never have their names
>> appear in that section.
>>
>> Also, people listed in ‘Active Contributors’ who become inactive have
>> had their names simply removed from the list so far.
>>
>> In light of this, it seems inconsistent to me to list on that page
>> people who contributed code such a long time ago, and by this make their
>> names more visible than those of more recent contributors.
>>
>> WDYT?
>>
>> Vincent
>>
>>
>>> On 12.09.2011 16:27:26 vhennebert wrote:
>>>> Author: vhennebert
>>>> Date: Mon Sep 12 14:27:25 2011
>>>> New Revision: 1169766
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
>>>> Log:
>>>> Bugzilla #51790: source file contains non-ascii character
>>>> Removed @author tags
>>>>
>>>> Modified:
>>>> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
>>>>
>>>> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
>>>> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
>>>> ==============================================================================
>>>> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java (original)
>>>> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon Sep 12 14:27:25 2011
>>>> @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
>>>> /**
>>>> * RTF Handler: generates RTF output using the structure events from
>>>> * the FO Tree sent to this structure handler.
>>>> - *
>>>> - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
>>>> - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
>>>> - * @author Boris Poudérous <bo...@eads-telecom.com>
>>>> - * @author Peter Herweg <ph...@web.de>
>>>> - * @author Andreas Putz <a....@skynamics.com>
>>>> */
>>>> public class RTFHandler extends FOEventHandler {
>>>>
>>>
>>>
>>>
>>> Jeremias Maerki
>>>
>
>
>
>
> Jeremias Maerki
>
Re: svn commit: r1169766 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
You're right. I think there's a lot of inconsistency here. So, why not
keep it VERY simple?
1. Wipe the team page clean.
2. Add a paragraph with a alphabetically sorted, comma-separated list of
names of contributors (without mail addresses, includes committers). The
listing would be regardless of the amount of work on FOP. If need be,
the committers in bold.
3. Add a link to
http://people.apache.org/committers-by-project.html#xmlgraphics-fop
(which, unfortunately, doesn't contain the list of committers before the
move from CVS to SVN).
4. Possibly restore the note about FOP's founder.
No more active or inactive contributors/committers (is he still active?
is he not?...). Every committer makes sure that the names of
contributors make it to the contributor list. We know who the candidates
for committership are from our daily work. I think that would increase
fairness and maintainability of the team list. And it allows to remove
all author tags and comments in a fair way. If any committer thinks that
the amount of recognition for the project is important, we can always
add a link to the Ohloh page of FOP which does a much better job at
telling who contributed how much and when.
That an idea?
On 14.09.2011 12:12:25 Vincent Hennebert wrote:
> On 14/09/11 07:54, Jeremias Maerki wrote:
> > +1 in general on removing author tags (it's a board recommendation after
> > all). But strong -1 on removing them without adding them to some central
> > list of contributors.
>
> Makes sense, although theres something Im not too sure about.
>
> Those of the contributors who were committers are already listed in the
> websites team page. Regarding the other ones, we could add a Past
> Contributors section to that page.
>
> However, current contributors who submit a patch on a one-off basis,
> therefore will never become committers, will never have their names
> appear in that section.
>
> Also, people listed in Active Contributors who become inactive have
> had their names simply removed from the list so far.
>
> In light of this, it seems inconsistent to me to list on that page
> people who contributed code such a long time ago, and by this make their
> names more visible than those of more recent contributors.
>
> WDYT?
>
> Vincent
>
>
> > On 12.09.2011 16:27:26 vhennebert wrote:
> >> Author: vhennebert
> >> Date: Mon Sep 12 14:27:25 2011
> >> New Revision: 1169766
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
> >> Log:
> >> Bugzilla #51790: source file contains non-ascii character
> >> Removed @author tags
> >>
> >> Modified:
> >> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> >>
> >> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> >> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
> >> ==============================================================================
> >> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java (original)
> >> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon Sep 12 14:27:25 2011
> >> @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
> >> /**
> >> * RTF Handler: generates RTF output using the structure events from
> >> * the FO Tree sent to this structure handler.
> >> - *
> >> - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
> >> - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
> >> - * @author Boris Poudérous <bo...@eads-telecom.com>
> >> - * @author Peter Herweg <ph...@web.de>
> >> - * @author Andreas Putz <a....@skynamics.com>
> >> */
> >> public class RTFHandler extends FOEventHandler {
> >>
> >
> >
> >
> > Jeremias Maerki
> >
Jeremias Maerki
Re: GIT (was: svn commit: r1169766 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java)
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
I know many people would love the ASF to move to GIT as the primary
repository. Or Mercurial. Or... At the moment, SVN is the only SCM
supported by the ASF infrastructure team.
http://www.apache.org/foundation/records/minutes/2010/board_minutes_2010_09_22.txt
Apparently, the infrastructure team has been looking into making GIT
work with the ASF way of things. There seem to be legal issues imposed
by a distributed SCM, too. At the moment, the following is available,
but not more: http://www.apache.org/dev/git.html
On 14.09.2011 17:09:13 Glenn Adams wrote:
> ok, that's a reasonable argument for not attempting to track in line;
>
> btw, it would be nice to convert to GIT some time as the primary repo
>
> On Wed, Sep 14, 2011 at 8:42 AM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
>
> > On 14.09.2011 15:07:11 Glenn Adams wrote:
> > > i don't understand why they should be removed even if replaced by a
> > common
> > > list:
> >
> > First of all because of a ASF board recommendation:
> >
> > http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
> >
> > http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt
> >
> > And seeing how many ASF projects follow that, it can be considered a
> > majority opinion around here.
> >
> > > (1) citing authors in the source files they contribute helps future
> > efforts
> > > to research issues
> >
> > That's a job SVN and ViewVC are much better at.
> >
> > > (2) citing authors in the source files they contribute helps in
> > addressing
> > > any IPR issues that might arise
> >
> > Again, SVN does it much better.
> >
> > > (3) moving author citations to a common list will likely result in a
> > > disconnect between the author and the works they contributed, as the
> > binding
> > > will tend to be lost
> >
> > That's basically one intention behind it. There shall be no "gardens"
> > where some people don't dare touch because there is a strong bond
> > between a piece of code and its creator. Still, SVN/ViewVC can make the
> > connection where necessary.
> >
> > > (4) where is the harm in citing authors in the original contributions?
> >
> > See (3). And over time, other people work on the code. Over FOP's almost
> > 12 years, many dozens of people contributed to FOP, changing this and
> > that. So that initial information in the code gets more and more
> > inaccurate, especially if these people don't add their own names. Can
> > you still tell after a few years which lines really come from the
> > original author (just from looking at the source code)? Where we always
> > retain contributor information is the SVN commit message. Every
> > contribution from a non-committer has to be annotated with the
> > contributors name. So it's all in Subversion.
> >
> > Take this, for example:
> >
> > http://svn.apache.org/viewvc/xmlgraphics/fop/branches/Temp_ComplexScripts/src/java/org/apache/fop/area/Block.java?view=annotate
> > (lines 135-142, spepping rev 1136144)
> >
> > It says "spepping" because he applied your patch, but if you follow the
> > revision number, you'll find this:
> > http://svn.apache.org/viewvc?view=revision&revision=1136144
> >
> > So it's all documented who changed what. If everyone followed the old
> > CVS pattern of "Submitted by: <contributor>", we could even
> > automatically extract a contributor list from SVN.
> >
> > > overall, i don't see any upside to removing them, but only downside
> >
> > No information is lost. But it reduces redundancy and increases fairness.
> >
> > Anyway, no need to restart the discussions about the pros and cons here.
> > There were enough heated ones all over the place in 2003/2004. The
> > following search tells the story well:
> > http://apache.markmail.org/search/?q=author%20tags
> >
> > > if I were a voting member in this PMC, I would vote -1
> > >
> > > On Wed, Sep 14, 2011 at 12:54 AM, Jeremias Maerki <
> > dev@jeremias-maerki.ch>wrote:
> > >
> > > > +1 in general on removing author tags (it's a board recommendation
> > after
> > > > all). But strong -1 on removing them without adding them to some
> > central
> > > > list of contributors.
> > > >
> > > > On 12.09.2011 16:27:26 vhennebert wrote:
> > > > > Author: vhennebert
> > > > > Date: Mon Sep 12 14:27:25 2011
> > > > > New Revision: 1169766
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
> > > > > Log:
> > > > > Bugzilla #51790: source file contains non-ascii character
> > > > > Removed @author tags
> > > > >
> > > > > Modified:
> > > > >
> > > >
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > > > >
> > > > > Modified:
> > > >
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > > > > URL:
> > > >
> > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
> > > > >
> > > >
> > ==============================================================================
> > > > > ---
> > > >
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > > > (original)
> > > > > +++
> > > >
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon
> > > > Sep 12 14:27:25 2011
> > > > > @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
> > > > > /**
> > > > > * RTF Handler: generates RTF output using the structure events from
> > > > > * the FO Tree sent to this structure handler.
> > > > > - *
> > > > > - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
> > > > > - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
> > > > > - * @author Boris Poudérous <bo...@eads-telecom.com>
> > > > > - * @author Peter Herweg <ph...@web.de>
> > > > > - * @author Andreas Putz <a....@skynamics.com>
> > > > > */
> > > > > public class RTFHandler extends FOEventHandler {
> > > > >
> > > >
> > > >
> > > >
> > > > Jeremias Maerki
> > > >
> > > >
> >
> >
> >
> >
> > Jeremias Maerki
> >
> >
Jeremias Maerki
Re: svn commit: r1169766 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Posted by Glenn Adams <gl...@skynav.com>.
ok, that's a reasonable argument for not attempting to track in line;
btw, it would be nice to convert to GIT some time as the primary repo
On Wed, Sep 14, 2011 at 8:42 AM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
> On 14.09.2011 15:07:11 Glenn Adams wrote:
> > i don't understand why they should be removed even if replaced by a
> common
> > list:
>
> First of all because of a ASF board recommendation:
>
> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
>
> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt
>
> And seeing how many ASF projects follow that, it can be considered a
> majority opinion around here.
>
> > (1) citing authors in the source files they contribute helps future
> efforts
> > to research issues
>
> That's a job SVN and ViewVC are much better at.
>
> > (2) citing authors in the source files they contribute helps in
> addressing
> > any IPR issues that might arise
>
> Again, SVN does it much better.
>
> > (3) moving author citations to a common list will likely result in a
> > disconnect between the author and the works they contributed, as the
> binding
> > will tend to be lost
>
> That's basically one intention behind it. There shall be no "gardens"
> where some people don't dare touch because there is a strong bond
> between a piece of code and its creator. Still, SVN/ViewVC can make the
> connection where necessary.
>
> > (4) where is the harm in citing authors in the original contributions?
>
> See (3). And over time, other people work on the code. Over FOP's almost
> 12 years, many dozens of people contributed to FOP, changing this and
> that. So that initial information in the code gets more and more
> inaccurate, especially if these people don't add their own names. Can
> you still tell after a few years which lines really come from the
> original author (just from looking at the source code)? Where we always
> retain contributor information is the SVN commit message. Every
> contribution from a non-committer has to be annotated with the
> contributors name. So it's all in Subversion.
>
> Take this, for example:
>
> http://svn.apache.org/viewvc/xmlgraphics/fop/branches/Temp_ComplexScripts/src/java/org/apache/fop/area/Block.java?view=annotate
> (lines 135-142, spepping rev 1136144)
>
> It says "spepping" because he applied your patch, but if you follow the
> revision number, you'll find this:
> http://svn.apache.org/viewvc?view=revision&revision=1136144
>
> So it's all documented who changed what. If everyone followed the old
> CVS pattern of "Submitted by: <contributor>", we could even
> automatically extract a contributor list from SVN.
>
> > overall, i don't see any upside to removing them, but only downside
>
> No information is lost. But it reduces redundancy and increases fairness.
>
> Anyway, no need to restart the discussions about the pros and cons here.
> There were enough heated ones all over the place in 2003/2004. The
> following search tells the story well:
> http://apache.markmail.org/search/?q=author%20tags
>
> > if I were a voting member in this PMC, I would vote -1
> >
> > On Wed, Sep 14, 2011 at 12:54 AM, Jeremias Maerki <
> dev@jeremias-maerki.ch>wrote:
> >
> > > +1 in general on removing author tags (it's a board recommendation
> after
> > > all). But strong -1 on removing them without adding them to some
> central
> > > list of contributors.
> > >
> > > On 12.09.2011 16:27:26 vhennebert wrote:
> > > > Author: vhennebert
> > > > Date: Mon Sep 12 14:27:25 2011
> > > > New Revision: 1169766
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
> > > > Log:
> > > > Bugzilla #51790: source file contains non-ascii character
> > > > Removed @author tags
> > > >
> > > > Modified:
> > > >
> > >
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > > >
> > > > Modified:
> > >
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > > > URL:
> > >
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
> > > >
> > >
> ==============================================================================
> > > > ---
> > >
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > > (original)
> > > > +++
> > >
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon
> > > Sep 12 14:27:25 2011
> > > > @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
> > > > /**
> > > > * RTF Handler: generates RTF output using the structure events from
> > > > * the FO Tree sent to this structure handler.
> > > > - *
> > > > - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
> > > > - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
> > > > - * @author Boris Poudérous <bo...@eads-telecom.com>
> > > > - * @author Peter Herweg <ph...@web.de>
> > > > - * @author Andreas Putz <a....@skynamics.com>
> > > > */
> > > > public class RTFHandler extends FOEventHandler {
> > > >
> > >
> > >
> > >
> > > Jeremias Maerki
> > >
> > >
>
>
>
>
> Jeremias Maerki
>
>
Re: svn commit: r1169766 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
On 14.09.2011 15:07:11 Glenn Adams wrote:
> i don't understand why they should be removed even if replaced by a common
> list:
First of all because of a ASF board recommendation:
http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt
And seeing how many ASF projects follow that, it can be considered a
majority opinion around here.
> (1) citing authors in the source files they contribute helps future efforts
> to research issues
That's a job SVN and ViewVC are much better at.
> (2) citing authors in the source files they contribute helps in addressing
> any IPR issues that might arise
Again, SVN does it much better.
> (3) moving author citations to a common list will likely result in a
> disconnect between the author and the works they contributed, as the binding
> will tend to be lost
That's basically one intention behind it. There shall be no "gardens"
where some people don't dare touch because there is a strong bond
between a piece of code and its creator. Still, SVN/ViewVC can make the
connection where necessary.
> (4) where is the harm in citing authors in the original contributions?
See (3). And over time, other people work on the code. Over FOP's almost
12 years, many dozens of people contributed to FOP, changing this and
that. So that initial information in the code gets more and more
inaccurate, especially if these people don't add their own names. Can
you still tell after a few years which lines really come from the
original author (just from looking at the source code)? Where we always
retain contributor information is the SVN commit message. Every
contribution from a non-committer has to be annotated with the
contributors name. So it's all in Subversion.
Take this, for example:
http://svn.apache.org/viewvc/xmlgraphics/fop/branches/Temp_ComplexScripts/src/java/org/apache/fop/area/Block.java?view=annotate
(lines 135-142, spepping rev 1136144)
It says "spepping" because he applied your patch, but if you follow the
revision number, you'll find this:
http://svn.apache.org/viewvc?view=revision&revision=1136144
So it's all documented who changed what. If everyone followed the old
CVS pattern of "Submitted by: <contributor>", we could even
automatically extract a contributor list from SVN.
> overall, i don't see any upside to removing them, but only downside
No information is lost. But it reduces redundancy and increases fairness.
Anyway, no need to restart the discussions about the pros and cons here.
There were enough heated ones all over the place in 2003/2004. The
following search tells the story well:
http://apache.markmail.org/search/?q=author%20tags
> if I were a voting member in this PMC, I would vote -1
>
> On Wed, Sep 14, 2011 at 12:54 AM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
>
> > +1 in general on removing author tags (it's a board recommendation after
> > all). But strong -1 on removing them without adding them to some central
> > list of contributors.
> >
> > On 12.09.2011 16:27:26 vhennebert wrote:
> > > Author: vhennebert
> > > Date: Mon Sep 12 14:27:25 2011
> > > New Revision: 1169766
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
> > > Log:
> > > Bugzilla #51790: source file contains non-ascii character
> > > Removed @author tags
> > >
> > > Modified:
> > >
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > >
> > > Modified:
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > > URL:
> > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
> > >
> > ==============================================================================
> > > ---
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > (original)
> > > +++
> > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon
> > Sep 12 14:27:25 2011
> > > @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
> > > /**
> > > * RTF Handler: generates RTF output using the structure events from
> > > * the FO Tree sent to this structure handler.
> > > - *
> > > - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
> > > - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
> > > - * @author Boris Poudérous <bo...@eads-telecom.com>
> > > - * @author Peter Herweg <ph...@web.de>
> > > - * @author Andreas Putz <a....@skynamics.com>
> > > */
> > > public class RTFHandler extends FOEventHandler {
> > >
> >
> >
> >
> > Jeremias Maerki
> >
> >
Jeremias Maerki
Re: svn commit: r1169766 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Posted by Glenn Adams <gl...@skynav.com>.
i don't understand why they should be removed even if replaced by a common
list:
(1) citing authors in the source files they contribute helps future efforts
to research issues
(2) citing authors in the source files they contribute helps in addressing
any IPR issues that might arise
(3) moving author citations to a common list will likely result in a
disconnect between the author and the works they contributed, as the binding
will tend to be lost
(4) where is the harm in citing authors in the original contributions?
overall, i don't see any upside to removing them, but only downside
if I were a voting member in this PMC, I would vote -1
On Wed, Sep 14, 2011 at 12:54 AM, Jeremias Maerki <de...@jeremias-maerki.ch>wrote:
> +1 in general on removing author tags (it's a board recommendation after
> all). But strong -1 on removing them without adding them to some central
> list of contributors.
>
> On 12.09.2011 16:27:26 vhennebert wrote:
> > Author: vhennebert
> > Date: Mon Sep 12 14:27:25 2011
> > New Revision: 1169766
> >
> > URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
> > Log:
> > Bugzilla #51790: source file contains non-ascii character
> > Removed @author tags
> >
> > Modified:
> >
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> >
> > Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> > URL:
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
> >
> ==============================================================================
> > ---
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> (original)
> > +++
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon
> Sep 12 14:27:25 2011
> > @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
> > /**
> > * RTF Handler: generates RTF output using the structure events from
> > * the FO Tree sent to this structure handler.
> > - *
> > - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
> > - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
> > - * @author Boris Poudérous <bo...@eads-telecom.com>
> > - * @author Peter Herweg <ph...@web.de>
> > - * @author Andreas Putz <a....@skynamics.com>
> > */
> > public class RTFHandler extends FOEventHandler {
> >
>
>
>
> Jeremias Maerki
>
>
Re: svn commit: r1169766 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Posted by Vincent Hennebert <vh...@gmail.com>.
On 14/09/11 07:54, Jeremias Maerki wrote:
> +1 in general on removing author tags (it's a board recommendation after
> all). But strong -1 on removing them without adding them to some central
> list of contributors.
Makes sense, although there’s something I’m not too sure about.
Those of the contributors who were committers are already listed in the
website’s team page. Regarding the other ones, we could add a ‘Past
Contributors’ section to that page.
However, current contributors who submit a patch on a one-off basis,
therefore will never become committers, will never have their names
appear in that section.
Also, people listed in ‘Active Contributors’ who become inactive have
had their names simply removed from the list so far.
In light of this, it seems inconsistent to me to list on that page
people who contributed code such a long time ago, and by this make their
names more visible than those of more recent contributors.
WDYT?
Vincent
> On 12.09.2011 16:27:26 vhennebert wrote:
>> Author: vhennebert
>> Date: Mon Sep 12 14:27:25 2011
>> New Revision: 1169766
>>
>> URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
>> Log:
>> Bugzilla #51790: source file contains non-ascii character
>> Removed @author tags
>>
>> Modified:
>> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
>>
>> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
>> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
>> ==============================================================================
>> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java (original)
>> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon Sep 12 14:27:25 2011
>> @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
>> /**
>> * RTF Handler: generates RTF output using the structure events from
>> * the FO Tree sent to this structure handler.
>> - *
>> - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
>> - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
>> - * @author Boris Poudérous <bo...@eads-telecom.com>
>> - * @author Peter Herweg <ph...@web.de>
>> - * @author Andreas Putz <a....@skynamics.com>
>> */
>> public class RTFHandler extends FOEventHandler {
>>
>
>
>
> Jeremias Maerki
>
Re: svn commit: r1169766 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
+1 in general on removing author tags (it's a board recommendation after
all). But strong -1 on removing them without adding them to some central
list of contributors.
On 12.09.2011 16:27:26 vhennebert wrote:
> Author: vhennebert
> Date: Mon Sep 12 14:27:25 2011
> New Revision: 1169766
>
> URL: http://svn.apache.org/viewvc?rev=1169766&view=rev
> Log:
> Bugzilla #51790: source file contains non-ascii character
> Removed @author tags
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java?rev=1169766&r1=1169765&r2=1169766&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/RTFHandler.java Mon Sep 12 14:27:25 2011
> @@ -132,12 +132,6 @@ import org.apache.fop.render.rtf.rtflib.
> /**
> * RTF Handler: generates RTF output using the structure events from
> * the FO Tree sent to this structure handler.
> - *
> - * @author Bertrand Delacretaz <bd...@codeconsult.ch>
> - * @author Trembicki-Guy, Ed <Gu...@DNB.com>
> - * @author Boris Poudérous <bo...@eads-telecom.com>
> - * @author Peter Herweg <ph...@web.de>
> - * @author Andreas Putz <a....@skynamics.com>
> */
> public class RTFHandler extends FOEventHandler {
>
Jeremias Maerki