You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sreenath Somarajapuram <ss...@hortonworks.com> on 2016/02/09 11:21:19 UTC

Review Request 43355: Tez Ambari View: Add protocol configuration for YARN

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43355/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-14951
    https://issues.apache.org/jira/browse/AMBARI-14951


Repository: ambari


Description
-------

- Value set in yarn.http.policy is required for creating task attempt log links, and we need a mechanism to get that configuration value at the UI side.
- As host points to Ambari proxy, there is no way to know the protocol at which yarn daemons are configured to run.


Diffs
-----

  contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 16b470a 
  contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java c1456bc 
  contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js c246536 
  contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java 8a50012 

Diff: https://reviews.apache.org/r/43355/diff/


Testing
-------

Tested locally on Ambari with latest Tez UI 1.


Thanks,

Sreenath Somarajapuram


Re: Review Request 43355: Tez Ambari View: Add protocol configuration for YARN

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43355/#review121305
-----------------------------------------------------------




contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java (line 277)
<https://reviews.apache.org/r/43355/#comment182987>

    What if the value is null.


- Alejandro Fernandez


On Feb. 9, 2016, 10:21 a.m., Sreenath Somarajapuram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43355/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 10:21 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-14951
>     https://issues.apache.org/jira/browse/AMBARI-14951
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Value set in yarn.http.policy is required for creating task attempt log links, and we need a mechanism to get that configuration value at the UI side.
> - As host points to Ambari proxy, there is no way to know the protocol at which yarn daemons are configured to run.
> 
> 
> Diffs
> -----
> 
>   contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 16b470a 
>   contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java c1456bc 
>   contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js c246536 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java 8a50012 
> 
> Diff: https://reviews.apache.org/r/43355/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on Ambari with latest Tez UI 1.
> 
> 
> Thanks,
> 
> Sreenath Somarajapuram
> 
>


Re: Review Request 43355: Tez Ambari View: Add protocol configuration for YARN

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43355/#review121297
-----------------------------------------------------------


Ship it!




Ship It!

- Yusaku Sako


On Feb. 9, 2016, 10:21 a.m., Sreenath Somarajapuram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43355/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 10:21 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-14951
>     https://issues.apache.org/jira/browse/AMBARI-14951
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Value set in yarn.http.policy is required for creating task attempt log links, and we need a mechanism to get that configuration value at the UI side.
> - As host points to Ambari proxy, there is no way to know the protocol at which yarn daemons are configured to run.
> 
> 
> Diffs
> -----
> 
>   contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 16b470a 
>   contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java c1456bc 
>   contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js c246536 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java 8a50012 
> 
> Diff: https://reviews.apache.org/r/43355/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on Ambari with latest Tez UI 1.
> 
> 
> Thanks,
> 
> Sreenath Somarajapuram
> 
>


Re: Review Request 43355: Tez Ambari View: Add protocol configuration for YARN

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43355/#review121300
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 9, 2016, 10:21 a.m., Sreenath Somarajapuram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43355/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 10:21 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-14951
>     https://issues.apache.org/jira/browse/AMBARI-14951
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Value set in yarn.http.policy is required for creating task attempt log links, and we need a mechanism to get that configuration value at the UI side.
> - As host points to Ambari proxy, there is no way to know the protocol at which yarn daemons are configured to run.
> 
> 
> Diffs
> -----
> 
>   contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 16b470a 
>   contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java c1456bc 
>   contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js c246536 
>   contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java 8a50012 
> 
> Diff: https://reviews.apache.org/r/43355/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on Ambari with latest Tez UI 1.
> 
> 
> Thanks,
> 
> Sreenath Somarajapuram
> 
>