[GitHub] [netbeans] jlahoda commented on pull request #2542: [NETBEANS-5034] fix wrong javadoc error hint

[GitBox <gi...@apache.org>]

jlahoda commented on pull request #2542:
URL: https://github.com/apache/netbeans/pull/2542#issuecomment-731947558


   I think this fix (removing `!t.hasOptionalEndTag()` in start element) is great.I'd suggest to add a test, like:
   
   ```
       public void testOptionalEndTag() throws Exception {
           HintTest.create()
                   .input(
                   "package test;\n" +
                   "/**\n" +
                   " * <ul><li>One<li>Two</li></ul>\n" +
                   " */\n" +
                   "class Zima {\n" +
                   "}\n")
                   .preference(AVAILABILITY_KEY + true, true)
                   .preference(SCOPE_KEY, "private")
                   .run(JavadocHint.class)
                   .assertWarnings();
       }
   ```
   
   in `java/javadoc/test/unit/src/org/netbeans/modules/javadoc/hints/Analyzer2Test.java`.
   
   Sorry for the trouble!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists