[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient

[GitBox <gi...@apache.org>]

mbwaheed commented on a change in pull request #1359: SOLR-13101: Make dir hash computation optional and resilient
URL: https://github.com/apache/lucene-solr/pull/1359#discussion_r394589235
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/store/blob/metadata/ServerSideMetadata.java
 ##########
 @@ -214,23 +228,23 @@ public String getDirectoryHash() {
 
   /**
    * Returns <code>true</code> if the contents of the directory passed into this method is identical to the contents of
-   * the directory of the Solr core of this instance, taken at instance creation time.<p>
+   * the directory of the Solr core of this instance, taken at instance creation time. If the directory hash was not 
+   * computed at the instance creation time, then this returns <code>false</code>
 
 Review comment:
   If directory hash was not computed I would throw IllegalStateException instead of returning false. This will help identify the programming error faster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org