You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/04/02 03:51:44 UTC
[GitHub] [incubator-dolphinscheduler] uuyuu opened a new pull request #2363:
add stop spark task instance feature
uuyuu opened a new pull request #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
make it easy to stop a spark task which run at other machine
## Brief change log
support stop spark task instance
## Verify this pull request
This pull request is code cleanup without any test coverage, but I have manual test it.
- *mvn -U clean package -Prelease -Dmaven.test.skip=true*
- *get maven package result from dolphinscheduler-dist\target*
- *install DS, make sure the yarn machine is not the machine which Worker will running*
- *run a workflow with spark task, a streaming task will be better*
- *stop the spark task from task page*
I know the manual test is ugly, but I have no good idea to test DS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on
issue #2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on issue #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-607608021
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E.png' alt='E' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='4.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_coverage&view=list) [4.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] uuyuu commented on issue #2363: add
stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
uuyuu commented on issue #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-610197363
> -1
>
> 1, api cannot depend on server module
> 2. DS has a kill operation, why should you develop a kill operation yourself?
--------------
emm, the first one, api dependon server module surely not reasonable, I agree；but the second one, DS current kill operation will not work when yarn is in other machine which diffrent from the work running machine, or, some scenes, I just want kill a task, not the whole workflow, so I think a kill operation in task level will better. Maybe the demand is too absurd, there are few such needs in practice... I just show my a little idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] break60 commented on issue #2363: add
stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
break60 commented on issue #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-607730214
Rerun pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2363:
add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-608972166
thanks for your first contribution, there are some things need to disscuss, you can send mail to dev@dolphinscheduler.apache.org or add wechat: 510570367, when add my wechat, please tell me your github id is uuyuu
thanks for your contribution again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-608971670
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E.png' alt='E' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='4.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_coverage&view=list) [4.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2363:
add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-608971279
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363?src=pr&el=h1) Report
> Merging [#2363](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/bd6adf284d77fcd3b997da3d20fd8a408e066e34&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `12.01%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2363 +/- ##
============================================
- Coverage 31.79% 31.68% -0.11%
Complexity 1797 1797
============================================
Files 343 343
Lines 18137 18202 +65
Branches 2277 2280 +3
============================================
+ Hits 5766 5767 +1
- Misses 11755 11819 +64
Partials 616 616
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...phinscheduler/api/service/TaskInstanceService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGFza0luc3RhbmNlU2VydmljZS5qYXZh) | `57.62% <0.00%> (-25.30%)` | `5.00 <0.00> (ø)` | |
| [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `5.11% <0.00%> (-0.06%)` | `4.00 <0.00> (ø)` | |
| [...pache/dolphinscheduler/common/utils/HttpUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0h0dHBVdGlscy5qYXZh) | `47.27% <0.00%> (-24.95%)` | `3.00 <0.00> (ø)` | |
| [...heduler/api/controller/TaskInstanceController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvVGFza0luc3RhbmNlQ29udHJvbGxlci5qYXZh) | `10.00% <6.25%> (-12.23%)` | `2.00 <1.00> (ø)` | |
| [...he/dolphinscheduler/server/utils/ProcessUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1Byb2Nlc3NVdGlscy5qYXZh) | `15.03% <15.64%> (-1.52%)` | `8.00 <8.00> (ø)` | |
| [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100.00% <100.00%> (ø)` | `5.00 <0.00> (ø)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `91.30% <0.00%> (-8.70%)` | `7.00% <0.00%> (-1.00%)` | |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `71.42% <0.00%> (+28.57%)` | `3.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363?src=pr&el=footer). Last update [bd6adf2...d222adc](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2363: add stop spark task instance feature
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-607608021
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E.png' alt='E' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2363&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='4.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_coverage&view=list) [4.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.4%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2363&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #2363:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on pull request #2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on pull request #2363:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-657938757
> > -1
> > 1, api cannot depend on server module
> > 2. DS has a kill operation, why should you develop a kill operation yourself?
>
> emm, the first one, api dependon server module surely not reasonable, I agree；but the second one, DS current kill operation will not work when yarn is in other machine which diffrent from the work running machine, or, some scenes, I just want kill a task, not the whole workflow, so I think a kill operation in task level will better. Maybe the demand is too absurd, there are few such needs in practice... I just show my a little idea.
yarn-client and yarn-cluster different is driver log print . appId we can collected and use sudo kill -9 Pid and yarn application -kill appId
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhongjiajie commented on a change in pull request #2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #2363:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#discussion_r415080037
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
##########
@@ -16,7 +16,6 @@
*/
package org.apache.dolphinscheduler.api.controller;
-
Review comment:
[DISCUSS] Not related to this PR, should we add static test for our codebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gabrywu commented on pull request #2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
gabrywu commented on pull request #2363:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-657448977
> > -1
> > 1, api cannot depend on server module
> > 2. DS has a kill operation, why should you develop a kill operation yourself?
>
> emm, the first one, api dependon server module surely not reasonable, I agree；but the second one, DS current kill operation will not work when yarn is in other machine which diffrent from the work running machine, or, some scenes, I just want kill a task, not the whole workflow, so I think a kill operation in task level will better. Maybe the demand is too absurd, there are few such needs in practice... I just show my a little idea.
I think ds support a kill operation in task level ,right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #2363:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#issuecomment-666454856
thanks for your first contribution, there are some things need to disscuss, you can add wechat: 510570367, when add my wechat, please tell me your github id is uuyuu
thanks for your contribution again, I will close this PR temporarily
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhongjiajie commented on a change in pull request #2363: add stop spark task instance feature
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #2363:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2363#discussion_r415081665
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
##########
@@ -16,7 +16,6 @@
*/
package org.apache.dolphinscheduler.api.controller;
-
Review comment:
I create a ISSUE to discuss this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org