You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/04/17 06:43:44 UTC

Review Request 20443: Integrate Deploy DB Into windows msi installer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20443/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271


Repository: cloudstack-git


Description
-------

Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence


Diffs
-----

  Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 
  client/pom.xml aee2672 
  scripts/database/cloudstack-setup-databases PRE-CREATION 
  scripts/installer/windows/Setup_Databases.wxs PRE-CREATION 
  scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION 
  scripts/installer/windows/acs.wxs 0e7dea7 

Diff: https://reviews.apache.org/r/20443/diff/


Testing
-------

Tested against Windows 2008 R2 server as changes are related to build process.


Thanks,

Damodar Reddy Talakanti


Re: Review Request 20443: Integrate Deploy DB Into windows msi installer

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20443/#review41587
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On April 24, 2014, 4:35 p.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20443/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 4:35 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Koushik Das.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence
> 
> 
> Diffs
> -----
> 
>   Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 
>   client/pom.xml aee2672 
>   scripts/installer/windows/Setup_Databases.wxs PRE-CREATION 
>   scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION 
>   scripts/installer/windows/acs.wxs 0e7dea7 
> 
> Diff: https://reviews.apache.org/r/20443/diff/
> 
> 
> Testing
> -------
> 
> Tested against Windows 2008 R2 server as changes are related to build process.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Re: Review Request 20443: Integrate Deploy DB Into windows msi installer

Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20443/
-----------------------------------------------------------

(Updated April 24, 2014, 4:35 p.m.)


Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Koushik Das.


Changes
-------

Added Frank to the reviewer's list


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271


Repository: cloudstack-git


Description
-------

Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence


Diffs
-----

  Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 
  client/pom.xml aee2672 
  scripts/installer/windows/Setup_Databases.wxs PRE-CREATION 
  scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION 
  scripts/installer/windows/acs.wxs 0e7dea7 

Diff: https://reviews.apache.org/r/20443/diff/


Testing
-------

Tested against Windows 2008 R2 server as changes are related to build process.


Thanks,

Damodar Reddy Talakanti


Re: Review Request 20443: Integrate Deploy DB Into windows msi installer

Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20443/
-----------------------------------------------------------

(Updated April 18, 2014, 4:48 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Changes
-------

Moved changes to cloud-setup-databases to a separate defect


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271


Repository: cloudstack-git


Description
-------

Currently MSI Installer assumes that the back end DB is already created. But going further deploy db should be part of installation instead of assumption. of existence


Diffs (updated)
-----

  Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 9bfe382 
  client/pom.xml aee2672 
  scripts/installer/windows/Setup_Databases.wxs PRE-CREATION 
  scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION 
  scripts/installer/windows/acs.wxs 0e7dea7 

Diff: https://reviews.apache.org/r/20443/diff/


Testing
-------

Tested against Windows 2008 R2 server as changes are related to build process.


Thanks,

Damodar Reddy Talakanti