[GitHub] [pulsar] sijie commented on issue #4623: Fixed the default port for https and http in admin client

[GitBox <gi...@apache.org>]

sijie commented on issue #4623: Fixed the default port for https and http in admin client
URL: https://github.com/apache/pulsar/pull/4623#issuecomment-507482783
 
 
   > I think the breaking change was in #3249. Before that, https was correctly resolving to 443 and http to 80.
   
   I don't think #3249 is a breaking change. If I remembered correctly, prior to #3249, you had to specify port in service url in order to make it work. it doesn't resolve directly to 443 for https or 80 for http. #3249 introduced the capability for resolving server url to default ports without specifying the port. I used 8080 for http and 8443 for https because those were the default ports when you setup a pulsar cluster.
   
   > This is seriously confusing. https://my-broker.com must mean port 443. If you use a different client, other than pulsar admin, you would have to specify :443.
   > Now, imagine debugging why the same url works in pulsar-admin but it doesn't if you try with http directly.
   
   agreed. If so, I would rather suggesting adding constraints that port is required. This will makes the behavior same as prior to #3249.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services