[jira] [Commented] (HIVE-2848) Add validation to HiveConf ConfVars

["Phabricator (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243994#comment-13243994 ] 

Phabricator commented on HIVE-2848:
-----------------------------------

njain has commented on the revision "HIVE-2848 [jira] Add validation to HiveConf ConfVars".

INLINE COMMENTS
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:600 Looks good - a minor change, can you change the type to a ENUM ?
  It will just make the code easier.

  Otherwise, the changes look good.
  ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java:138 Is this check valid ?

  I mean, aren't there hive parameters which dont start with "hive." ?

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:534 What will it take to change the default to true ?

  It should work - right, or will anything break ?

REVISION DETAIL
  https://reviews.facebook.net/D2313

                
> Add validation to HiveConf ConfVars
> -----------------------------------
>
>                 Key: HIVE-2848
>                 URL: https://issues.apache.org/jira/browse/HIVE-2848
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.9.0
>            Reporter: Kevin Wilfong
>            Assignee: Navis
>         Attachments: HIVE-2848.D2313.1.patch, HIVE-2848.D2313.2.patch
>
>
> It would be good if we could add some validation to ConfVars in the HiveConf when they are set.
> At least if a variable is supposed to be boolean, numeric, or strict/nonstrict, it shouldn't be too difficult to check for these.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira