[GitHub] [spark] cloud-fan commented on a change in pull request #31920: [SPARK-33604][SQL] Group exception messages in sql/execution

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31920:
URL: https://github.com/apache/spark/pull/31920#discussion_r611445404



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala
##########
@@ -205,7 +206,7 @@ object ExplainUtils extends AdaptiveSparkPlanHelper {
     case iter: Iterable[_] => s"${fieldName} [${iter.size}]: ${iter.mkString("[", ", ", "]")}"
     case str: String if (str == null || str.isEmpty) => s"${fieldName}: None"
     case str: String => s"${fieldName}: ${str}"
-    case _ => throw new IllegalArgumentException(s"Unsupported type for argument values: $values")

Review comment:
       isn't it assert like?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org