You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 14:48:28 UTC
[GitHub] [arrow] andygrove commented on a change in pull request #8473: ARROW-10320 [Rust] [DataFusion] Migrated from batch iterators to batch streams.
andygrove commented on a change in pull request #8473:
URL: https://github.com/apache/arrow/pull/8473#discussion_r506503915
##########
File path: rust/datafusion/src/physical_plan/merge.rs
##########
@@ -100,27 +103,29 @@ impl ExecutionPlan for MergeExec {
self.input.execute(0).await
}
_ => {
- let tasks = (0..input_partitions)
- .map(|part_i| {
- let input = self.input.clone();
- tokio::spawn(async move {
- let it = input.execute(part_i).await?;
- common::collect(it)
- })
+ let tasks = (0..input_partitions).map(|part_i| {
+ let input = self.input.clone();
+ tokio::spawn(async move {
+ let stream = input.execute(part_i).await?;
+ common::collect(stream).await
Review comment:
Yes, collect is the reason we don't see better performance from this PR IMO. I agree that this can be fixed in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org