You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/01/10 21:13:43 UTC
[GitHub] [accumulo] DomGarguilo opened a new issue #2413: OfflineIterator forks ScanDataSource code and doesn't close readers
DomGarguilo opened a new issue #2413:
URL: https://github.com/apache/accumulo/issues/2413
From Jira ticket: [ACCUMULO-1303](https://issues.apache.org/jira/browse/ACCUMULO-1303)
The original ticket states:
> createIterator seems to share a bit of code with Tablet, which is just copied instead of reused. This can cause issues down the road if the code in one side changes. If we can try to use the same code base for this logic, it would be better. This may also help with leaving the readers open as well.
It was also pointed out that the code that is shared was eventually moved from Tablet to ScanDataSource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on issue #2413: OfflineIterator forks ScanDataSource code and doesn't close readers
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on issue #2413:
URL: https://github.com/apache/accumulo/issues/2413#issuecomment-1013227816
Looks like the two sources have diverged pretty far and it may not be possible to cleanly consolidate the two.
I am looking into the second part of the issue now - closing the readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo closed issue #2413: OfflineIterator forks ScanDataSource code and doesn't close readers
Posted by GitBox <gi...@apache.org>.
DomGarguilo closed issue #2413:
URL: https://github.com/apache/accumulo/issues/2413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org