You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Victor Salaman (JIRA)" <ji...@apache.org> on 2008/01/21 12:07:23 UTC
[jira] Created: (CAMEL-300) Incorrect maven-bundle-plugin settings
cause class duplication in several modules
Incorrect maven-bundle-plugin settings cause class duplication in several modules
---------------------------------------------------------------------------------
Key: CAMEL-300
URL: https://issues.apache.org/activemq/browse/CAMEL-300
Project: Apache Camel
Issue Type: Bug
Affects Versions: 1.2.0, 1.3.0
Reporter: Victor Salaman
In the camel-spring module the osgi.export property is too greedy. Since the maven-bundle-plugin uses ANY resource even if it's a dependency, by specifying org.apache.camel.component* actually bundles everything under that package from any dependency in the POM, in this case camel-core.
<properties>
<camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component*</camel.osgi.export.pkg>
</properties>
It should be replaced to something like:
<properties>
<camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component.event*,org.apache.camel.component.xslt*,org.apache.camel.component.vali
dator*</camel.osgi.export.pkg>
</properties>
---
The camel-stream component suffers from the same symptom.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-300) Incorrect maven-bundle-plugin
settings cause class duplication in several modules
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45807#action_45807 ]
Claus Ibsen commented on CAMEL-300:
-----------------------------------
Hadrian we should start considering doing anything with this. If we start cutting a RC of Camel 1.5 then I guess we should have the OSGi bundles sorted.
> Incorrect maven-bundle-plugin settings cause class duplication in several modules
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-300
> URL: https://issues.apache.org/activemq/browse/CAMEL-300
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Victor Salaman
> Assignee: Hadrian Zbarcea
> Fix For: 1.5.0
>
>
> In the camel-spring module the osgi.export property is too greedy. Since the maven-bundle-plugin uses ANY resource even if it's a dependency, by specifying org.apache.camel.component* actually bundles everything under that package from any dependency in the POM, in this case camel-core.
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component*</camel.osgi.export.pkg>
> </properties>
> It should be replaced to something like:
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component.event*,org.apache.camel.component.xslt*,org.apache.camel.component.vali
> dator*</camel.osgi.export.pkg>
> </properties>
> ---
> The camel-stream component suffers from the same symptom.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-300) Incorrect maven-bundle-plugin
settings cause class duplication in several modules
Posted by "Victor Salaman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41102#action_41102 ]
Victor Salaman commented on CAMEL-300:
--------------------------------------
A better solution actually would be leave the property as is, and modify the plugin definition in the main pom, so that it sets the "excludeDependencies" element to "true" or some configurable property. IMHO it should be set to true, since in a module bunlde you don't want the side effect of inclusion of classes outside the module.
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>${felix-version}</version>
<extensions>true</extensions>
<configuration>
<excludeDependencies>true</excludeDependencies>
<instructions>
<Bundle-Name>${artifactId}</Bundle-Name>
<Bundle-SymbolicName>${camel.osgi.symbolic.name}</Bundle-SymbolicName>
<Export-Package>${camel.osgi.export}</Export-Package>
<Import-Package>${camel.osgi.import}</Import-Package>
<Private-Package>${camel.osgi.private.pkg}</Private-Package>
<Implementation-Title>Apache Camel</Implementation-Title>
<Implementation-Version>${project.version}</Implementation-Version>
</instructions>
</configuration>
</plugin>
> Incorrect maven-bundle-plugin settings cause class duplication in several modules
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-300
> URL: https://issues.apache.org/activemq/browse/CAMEL-300
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Victor Salaman
>
> In the camel-spring module the osgi.export property is too greedy. Since the maven-bundle-plugin uses ANY resource even if it's a dependency, by specifying org.apache.camel.component* actually bundles everything under that package from any dependency in the POM, in this case camel-core.
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component*</camel.osgi.export.pkg>
> </properties>
> It should be replaced to something like:
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component.event*,org.apache.camel.component.xslt*,org.apache.camel.component.vali
> dator*</camel.osgi.export.pkg>
> </properties>
> ---
> The camel-stream component suffers from the same symptom.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-300) Incorrect maven-bundle-plugin settings
cause class duplication in several modules
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea resolved CAMEL-300.
-----------------------------------
Resolution: Fixed
> Incorrect maven-bundle-plugin settings cause class duplication in several modules
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-300
> URL: https://issues.apache.org/activemq/browse/CAMEL-300
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Victor Salaman
> Assignee: Hadrian Zbarcea
> Fix For: 1.5.0
>
>
> In the camel-spring module the osgi.export property is too greedy. Since the maven-bundle-plugin uses ANY resource even if it's a dependency, by specifying org.apache.camel.component* actually bundles everything under that package from any dependency in the POM, in this case camel-core.
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component*</camel.osgi.export.pkg>
> </properties>
> It should be replaced to something like:
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component.event*,org.apache.camel.component.xslt*,org.apache.camel.component.vali
> dator*</camel.osgi.export.pkg>
> </properties>
> ---
> The camel-stream component suffers from the same symptom.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-300) Incorrect maven-bundle-plugin
settings cause class duplication in several modules
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45809#action_45809 ]
Hadrian Zbarcea commented on CAMEL-300:
---------------------------------------
Agree. Looking into it now.
> Incorrect maven-bundle-plugin settings cause class duplication in several modules
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-300
> URL: https://issues.apache.org/activemq/browse/CAMEL-300
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Victor Salaman
> Assignee: Hadrian Zbarcea
> Fix For: 1.5.0
>
>
> In the camel-spring module the osgi.export property is too greedy. Since the maven-bundle-plugin uses ANY resource even if it's a dependency, by specifying org.apache.camel.component* actually bundles everything under that package from any dependency in the POM, in this case camel-core.
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component*</camel.osgi.export.pkg>
> </properties>
> It should be replaced to something like:
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component.event*,org.apache.camel.component.xslt*,org.apache.camel.component.vali
> dator*</camel.osgi.export.pkg>
> </properties>
> ---
> The camel-stream component suffers from the same symptom.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-300) Incorrect maven-bundle-plugin settings
cause class duplication in several modules
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea reassigned CAMEL-300:
-------------------------------------
Assignee: Hadrian Zbarcea
> Incorrect maven-bundle-plugin settings cause class duplication in several modules
> ---------------------------------------------------------------------------------
>
> Key: CAMEL-300
> URL: https://issues.apache.org/activemq/browse/CAMEL-300
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Victor Salaman
> Assignee: Hadrian Zbarcea
> Fix For: 1.5.0
>
>
> In the camel-spring module the osgi.export property is too greedy. Since the maven-bundle-plugin uses ANY resource even if it's a dependency, by specifying org.apache.camel.component* actually bundles everything under that package from any dependency in the POM, in this case camel-core.
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component*</camel.osgi.export.pkg>
> </properties>
> It should be replaced to something like:
> <properties>
> <camel.osgi.export.pkg>org.apache.camel.spring*,org.apache.camel.component.event*,org.apache.camel.component.xslt*,org.apache.camel.component.vali
> dator*</camel.osgi.export.pkg>
> </properties>
> ---
> The camel-stream component suffers from the same symptom.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.