You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2012/07/02 12:17:39 UTC

Review Request: Fix a few bugs in the waf rpm build

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5697/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

With this patch i add all the new plugin jars to the cloud-server rpm and make sure they are in classpath.conf.
Also included cloud_utils.py that was omitted from the cloud-python rpm, but required by cloud-setup-database.


Diffs
-----

  cloud.spec 83af1e6 
  wscript_build 4c4f1e4 
  wscript_configure d437f3a 

Diff: https://reviews.apache.org/r/5697/diff/


Testing
-------

./waf --package-version=3.0.3 --release-version=3 --verbose rpm
yum install cloud-agent-scripts-3.0.3-3.el6.x86_64.rpm cloud-aws-api-3.0.3-3.el6.x86_64.rpm cloud-cli-3.0.3-3.el6.x86_64.rpm cloud-client-3.0.3-3.el6.x86_64.rpm \
            cloud-client-ui-3.0.3-3.el6.x86_64.rpm cloud-core-3.0.3-3.el6.x86_64.rpm cloud-deps-3.0.3-3.el6.x86_64.rpm cloud-python-3.0.3-3.el6.x86_64.rpm \
            cloud-server-3.0.3-3.el6.x86_64.rpm cloud-setup-3.0.3-3.el6.x86_64.rpm cloud-usage-3.0.3-3.el6.x86_64.rpm cloud-utils-3.0.3-3.el6.x86_64.rpm
cloud-setup-databases --deploy-as=xxxxx:xxxxxx cloud:cloud
cloud-setup-management
/etc/init.d/cloud-management start

login on the client


Thanks,

Hugo Trippaers


Re: Review Request: Fix a few bugs in the waf rpm build

Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5697/#review8803
-----------------------------------------------------------

Ship it!


worksforme, committed

- David Nalley


On July 2, 2012, 10:17 a.m., Hugo Trippaers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5697/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 10:17 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> With this patch i add all the new plugin jars to the cloud-server rpm and make sure they are in classpath.conf.
> Also included cloud_utils.py that was omitted from the cloud-python rpm, but required by cloud-setup-database.
> 
> 
> Diffs
> -----
> 
>   cloud.spec 83af1e6 
>   wscript_build 4c4f1e4 
>   wscript_configure d437f3a 
> 
> Diff: https://reviews.apache.org/r/5697/diff/
> 
> 
> Testing
> -------
> 
> ./waf --package-version=3.0.3 --release-version=3 --verbose rpm
> yum install cloud-agent-scripts-3.0.3-3.el6.x86_64.rpm cloud-aws-api-3.0.3-3.el6.x86_64.rpm cloud-cli-3.0.3-3.el6.x86_64.rpm cloud-client-3.0.3-3.el6.x86_64.rpm \
>             cloud-client-ui-3.0.3-3.el6.x86_64.rpm cloud-core-3.0.3-3.el6.x86_64.rpm cloud-deps-3.0.3-3.el6.x86_64.rpm cloud-python-3.0.3-3.el6.x86_64.rpm \
>             cloud-server-3.0.3-3.el6.x86_64.rpm cloud-setup-3.0.3-3.el6.x86_64.rpm cloud-usage-3.0.3-3.el6.x86_64.rpm cloud-utils-3.0.3-3.el6.x86_64.rpm
> cloud-setup-databases --deploy-as=xxxxx:xxxxxx cloud:cloud
> cloud-setup-management
> /etc/init.d/cloud-management start
> 
> login on the client
> 
> 
> Thanks,
> 
> Hugo Trippaers
> 
>


Re: Review Request: Fix a few bugs in the waf rpm build

Posted by Murali Reddy <Mu...@citrix.com>.
On 02/07/12 6:29 AM, "Hugo Trippaers" <ht...@schubergphilis.com>
wrote:

>
>
>> On July 2, 2012, 1:02 p.m., David Nalley wrote:
>> > Murali, Chiradeep: You guys have been the ones working on the plugin
>>stuff - is this your intent that all of the plugins would be bundled in
>>-server? 
>> > 
>> > --David
>
>I hope the answer is no ;-)   Eventually i guess the idea is that plugins
>can be shipped separately and installed/enabled on demand. However i
>think that for the time being putting them in the -server bundle will
>allow us to make rpms, more of a stop-gap than an actual solution.
>
>
>- Hugo

Yes, it is a stop-gap solution to bundle necessary jar's from plug-ins
into server, agent etc. As Hugo mentioned in long-term its desirable to
have independent life-cycle for plug-in's and this is one of the intents
of proposed effort [1].

[1]http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201206
.mbox/%3CB1DF26ECC0458748AC97CECE2DA98D41011D284D189B@SJCPMAILBOX01.citrite
.net%3E


Re: Review Request: Fix a few bugs in the waf rpm build

Posted by Hugo Trippaers <ht...@schubergphilis.com>.

> On July 2, 2012, 1:02 p.m., David Nalley wrote:
> > Murali, Chiradeep: You guys have been the ones working on the plugin stuff - is this your intent that all of the plugins would be bundled in -server? 
> > 
> > --David

I hope the answer is no ;-)   Eventually i guess the idea is that plugins can be shipped separately and installed/enabled on demand. However i think that for the time being putting them in the -server bundle will allow us to make rpms, more of a stop-gap than an actual solution.


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5697/#review8784
-----------------------------------------------------------


On July 2, 2012, 10:17 a.m., Hugo Trippaers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5697/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 10:17 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> With this patch i add all the new plugin jars to the cloud-server rpm and make sure they are in classpath.conf.
> Also included cloud_utils.py that was omitted from the cloud-python rpm, but required by cloud-setup-database.
> 
> 
> Diffs
> -----
> 
>   cloud.spec 83af1e6 
>   wscript_build 4c4f1e4 
>   wscript_configure d437f3a 
> 
> Diff: https://reviews.apache.org/r/5697/diff/
> 
> 
> Testing
> -------
> 
> ./waf --package-version=3.0.3 --release-version=3 --verbose rpm
> yum install cloud-agent-scripts-3.0.3-3.el6.x86_64.rpm cloud-aws-api-3.0.3-3.el6.x86_64.rpm cloud-cli-3.0.3-3.el6.x86_64.rpm cloud-client-3.0.3-3.el6.x86_64.rpm \
>             cloud-client-ui-3.0.3-3.el6.x86_64.rpm cloud-core-3.0.3-3.el6.x86_64.rpm cloud-deps-3.0.3-3.el6.x86_64.rpm cloud-python-3.0.3-3.el6.x86_64.rpm \
>             cloud-server-3.0.3-3.el6.x86_64.rpm cloud-setup-3.0.3-3.el6.x86_64.rpm cloud-usage-3.0.3-3.el6.x86_64.rpm cloud-utils-3.0.3-3.el6.x86_64.rpm
> cloud-setup-databases --deploy-as=xxxxx:xxxxxx cloud:cloud
> cloud-setup-management
> /etc/init.d/cloud-management start
> 
> login on the client
> 
> 
> Thanks,
> 
> Hugo Trippaers
> 
>


Re: Review Request: Fix a few bugs in the waf rpm build

Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5697/#review8784
-----------------------------------------------------------


Murali, Chiradeep: You guys have been the ones working on the plugin stuff - is this your intent that all of the plugins would be bundled in -server? 

--David

- David Nalley


On July 2, 2012, 10:17 a.m., Hugo Trippaers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5697/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 10:17 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> With this patch i add all the new plugin jars to the cloud-server rpm and make sure they are in classpath.conf.
> Also included cloud_utils.py that was omitted from the cloud-python rpm, but required by cloud-setup-database.
> 
> 
> Diffs
> -----
> 
>   cloud.spec 83af1e6 
>   wscript_build 4c4f1e4 
>   wscript_configure d437f3a 
> 
> Diff: https://reviews.apache.org/r/5697/diff/
> 
> 
> Testing
> -------
> 
> ./waf --package-version=3.0.3 --release-version=3 --verbose rpm
> yum install cloud-agent-scripts-3.0.3-3.el6.x86_64.rpm cloud-aws-api-3.0.3-3.el6.x86_64.rpm cloud-cli-3.0.3-3.el6.x86_64.rpm cloud-client-3.0.3-3.el6.x86_64.rpm \
>             cloud-client-ui-3.0.3-3.el6.x86_64.rpm cloud-core-3.0.3-3.el6.x86_64.rpm cloud-deps-3.0.3-3.el6.x86_64.rpm cloud-python-3.0.3-3.el6.x86_64.rpm \
>             cloud-server-3.0.3-3.el6.x86_64.rpm cloud-setup-3.0.3-3.el6.x86_64.rpm cloud-usage-3.0.3-3.el6.x86_64.rpm cloud-utils-3.0.3-3.el6.x86_64.rpm
> cloud-setup-databases --deploy-as=xxxxx:xxxxxx cloud:cloud
> cloud-setup-management
> /etc/init.d/cloud-management start
> 
> login on the client
> 
> 
> Thanks,
> 
> Hugo Trippaers
> 
>