You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by so...@apache.org on 2017/12/25 04:28:43 UTC
openmeetings git commit: [OPENMEETINGS-1803] some sonar issues are
addressed
Repository: openmeetings
Updated Branches:
refs/heads/4.0.x 71e594010 -> 8ddbf1e2c
[OPENMEETINGS-1803] some sonar issues are addressed
Project: http://git-wip-us.apache.org/repos/asf/openmeetings/repo
Commit: http://git-wip-us.apache.org/repos/asf/openmeetings/commit/8ddbf1e2
Tree: http://git-wip-us.apache.org/repos/asf/openmeetings/tree/8ddbf1e2
Diff: http://git-wip-us.apache.org/repos/asf/openmeetings/diff/8ddbf1e2
Branch: refs/heads/4.0.x
Commit: 8ddbf1e2c8aeaf8d0d81888684e35635b2125e3a
Parents: 71e5940
Author: Maxim Solodovnik <so...@gmail.com>
Authored: Mon Dec 25 11:28:35 2017 +0700
Committer: Maxim Solodovnik <so...@gmail.com>
Committed: Mon Dec 25 11:28:35 2017 +0700
----------------------------------------------------------------------
.../openmeetings/web/common/InvitationDialog.java | 6 +++---
.../org/apache/openmeetings/web/room/wb/tool-math.js | 12 ++++++------
pom.xml | 2 +-
3 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/8ddbf1e2/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/InvitationDialog.java
----------------------------------------------------------------------
diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/InvitationDialog.java b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/InvitationDialog.java
index dd2fa01..6474653 100644
--- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/InvitationDialog.java
+++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/common/InvitationDialog.java
@@ -30,9 +30,9 @@ import com.googlecode.wicket.jquery.ui.widget.dialog.DialogButton;
public class InvitationDialog extends AbstractFormDialog<Invitation> {
private static final long serialVersionUID = 1L;
- public DialogButton generate;
- public DialogButton send;
- public DialogButton cancel;
+ DialogButton generate;
+ DialogButton send;
+ DialogButton cancel;
private final InvitationForm form;
public InvitationDialog(String id, final InvitationForm _form) {
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/8ddbf1e2/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/tool-math.js
----------------------------------------------------------------------
diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/tool-math.js b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/tool-math.js
index 22f5680..73750cc 100644
--- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/tool-math.js
+++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/tool-math.js
@@ -42,6 +42,12 @@ var TMath = function(wb, s) {
const math = ShapeBase();
math.obj = null;
+ function highlight(el) {
+ el.addClass('ui-state-highlight', 2000, function() {
+ el.focus();
+ el.removeClass('ui-state-highlight', 2000);
+ });
+ }
math.mouseDown = function(o) {
const canvas = this
, pointer = canvas.getPointer(o.e)
@@ -55,12 +61,6 @@ var TMath = function(wb, s) {
} else {
const err = fml.find('.status');
err.text('');
- function highlight(el) {
- el.addClass('ui-state-highlight', 2000, function() {
- el.focus();
- el.removeClass('ui-state-highlight', 2000);
- });
- }
if (ta.val().trim() === '') {
highlight(ta);
return;
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/8ddbf1e2/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 85406b7..9e8ad33 100644
--- a/pom.xml
+++ b/pom.xml
@@ -79,7 +79,7 @@
<!-- URL of the ASF SonarQube server -->
<sonar.host.url>https://builds.apache.org/analysis</sonar.host.url>
<!-- Exclude all generated code -->
- <sonar.exclusions>file:**/generated-sources/**, file:**/fabric.js, file:**/cssemoticons.js, file:**/uuid.js, file:**/fileinput*.js</sonar.exclusions>
+ <sonar.exclusions>file:**/generated-sources/**, file:**/fabric.js, file:**/cssemoticons.js, file:**/uuid.js, file:**/fileinput*.js, file:**/MathJax.js</sonar.exclusions>
<sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
<sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
<sonar.jacoco.reportPath>${project.basedir}/../target/jacoco.exec</sonar.jacoco.reportPath>