You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/30 00:11:39 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #459: [YUNIKORN-1435] Expose RM state dump in REST API
craigcondit opened a new pull request, #459:
URL: https://github.com/apache/yunikorn-core/pull/459
### What is this PR for?
When an RM has registered as a `StateDumpPlugin`, its output will be included in the full state dump under the `RMDiagnostics` entry.
NOTE: This will be in draft status until https://github.com/apache/yunikorn-scheduler-interface/pull/79 is merged, since we need to update the SI.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1435
### How should this be tested?
Unit tests have been added.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #459: [YUNIKORN-1435] Expose RM state dump in REST API
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #459: [YUNIKORN-1435] Expose RM state dump in REST API
URL: https://github.com/apache/yunikorn-core/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit commented on pull request #459: [YUNIKORN-1435] Expose RM state dump in REST API
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #459:
URL: https://github.com/apache/yunikorn-core/pull/459#issuecomment-1334239514
> changes looks good. test cases needs to be added.
Existing test cases already cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #459: [YUNIKORN-1435] Expose RM state dump in REST API
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #459:
URL: https://github.com/apache/yunikorn-core/pull/459#issuecomment-1332492914
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#459](https://codecov.io/gh/apache/yunikorn-core/pull/459?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67f0efd) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/9b90e8ad9f834868971b36cd69284a03532de999?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b90e8a) will **decrease** coverage by `0.09%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 67f0efd differs from pull request most recent head d63750b. Consider uploading reports for the commit d63750b to get more accurate results
```diff
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 72.81% 72.72% -0.10%
==========================================
Files 67 67
Lines 9990 10023 +33
==========================================
+ Hits 7274 7289 +15
- Misses 2474 2490 +16
- Partials 242 244 +2
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/tests/mock\_rm\_callback.go](https://codecov.io/gh/apache/yunikorn-core/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci90ZXN0cy9tb2NrX3JtX2NhbGxiYWNrLmdv) | `28.57% <0.00%> (-4.77%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `77.61% <44.44%> (-1.03%)` | :arrow_down: |
| [pkg/plugins/plugins.go](https://codecov.io/gh/apache/yunikorn-core/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbnMvcGx1Z2lucy5nbw==) | `76.00% <60.00%> (-24.00%)` | :arrow_down: |
| [pkg/webservice/state\_dump.go](https://codecov.io/gh/apache/yunikorn-core/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `79.47% <100.00%> (+0.13%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] manirajv06 commented on pull request #459: [YUNIKORN-1435] Expose RM state dump in REST API
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on PR #459:
URL: https://github.com/apache/yunikorn-core/pull/459#issuecomment-1334781282
I can see asserts for some properties like Partitions, Nodes, ClusterInfo, Queues etc but for not for Applications, AppHistory, ContainerHistory and recently added RMDiagnostics. I think we should file a jira to cover the left out properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org