You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/18 21:57:29 UTC
Review Request 12737: Scope hiding/showing of button to "btn-toggle" class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12737/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
The "btn-mini" class is used in other places, like the "Browse" page, and should not always be hidden when it is a descendant of "table-condensed" or "inline".
Original review: https://reviews.apache.org/r/12616/
Diffs
-----
src/webui/master/static/css/mesos.css d1413b7797c6623d35ba0385e9a56a1eceefc568
src/webui/master/static/framework.html 97d25b7c2271e86a9e0fa201f53b7671c0d0ed26
src/webui/master/static/frameworks.html bcae4363eb802a28cff5defec6ecbeae86d7fc63
src/webui/master/static/home.html d45cc944f95d6fa0539e341982391024d0cb0514
src/webui/master/static/slave.html c923644d30c420bc6b0379ddc3965216e7cb7e5e
src/webui/master/static/slaves.html d9fd0f3d16e22c667decef24071cb132b17e35b8
Diff: https://reviews.apache.org/r/12737/diff/
Testing
-------
* Rendered each template with a .btn-mini copy button, copied text with it
* Viewed the "Browse" page to see the now visible "download" buttons
Thanks,
Ross Allen
Re: Review Request 12737: Scope hiding/showing of button to "btn-toggle"
class
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12737/#review23458
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 18, 2013, 7:57 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12737/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 7:57 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The "btn-mini" class is used in other places, like the "Browse" page, and should not always be hidden when it is a descendant of "table-condensed" or "inline".
>
> Original review: https://reviews.apache.org/r/12616/
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css d1413b7797c6623d35ba0385e9a56a1eceefc568
> src/webui/master/static/framework.html 97d25b7c2271e86a9e0fa201f53b7671c0d0ed26
> src/webui/master/static/frameworks.html bcae4363eb802a28cff5defec6ecbeae86d7fc63
> src/webui/master/static/home.html d45cc944f95d6fa0539e341982391024d0cb0514
> src/webui/master/static/slave.html c923644d30c420bc6b0379ddc3965216e7cb7e5e
> src/webui/master/static/slaves.html d9fd0f3d16e22c667decef24071cb132b17e35b8
>
> Diff: https://reviews.apache.org/r/12737/diff/
>
>
> Testing
> -------
>
> * Rendered each template with a .btn-mini copy button, copied text with it
> * Viewed the "Browse" page to see the now visible "download" buttons
>
>
> Thanks,
>
> Ross Allen
>
>