You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/16 19:30:39 UTC
[GitHub] [apisix] fatihbm opened a new pull request #6633: Adding -j parameter to the make.
fatihbm opened a new pull request #6633:
URL: https://github.com/apache/apisix/pull/6633
This parameter optional but useful if it has more than one cpu.
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass closed pull request #6633: Adding -j parameter to the make.
Posted by GitBox <gi...@apache.org>.
tzssangglass closed pull request #6633:
URL: https://github.com/apache/apisix/pull/6633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #6633: Adding -j parameter to the make.
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #6633:
URL: https://github.com/apache/apisix/pull/6633#issuecomment-1069784806
@fatihbm Could you rename the PR title according to https://github.com/zeke/semantic-pull-requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6633: Adding -j parameter to the make.
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6633:
URL: https://github.com/apache/apisix/pull/6633#issuecomment-1072008971
as @spacewander said, this does not help with parallel downloads (it is not actually a make compilation process).
I will turn it off because there is no practical use for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #6633: Adding -j parameter to the make.
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #6633:
URL: https://github.com/apache/apisix/pull/6633#issuecomment-1069839409
Hello there, I afraid this feat can't do help for more than one CPU scenario.
`make deps` will use luarocks to install deps defined in `rockspec/apisix-master-0.rockspec`. which is not parallelizable. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass closed pull request #6633: Adding -j parameter to the make.
Posted by GitBox <gi...@apache.org>.
tzssangglass closed pull request #6633:
URL: https://github.com/apache/apisix/pull/6633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6633: Adding -j parameter to the make.
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6633:
URL: https://github.com/apache/apisix/pull/6633#discussion_r828619812
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -124,7 +124,7 @@ Follow the steps below to install Apache APISIX via the source release package.
# Switch to the apisix-${APISIX_VERSION} directory
cd apisix-${APISIX_VERSION}
# Create dependencies
- make deps
+ make deps # -j$(nproc) ## use this parameter for make building go fast.
Review comment:
The `make deps` will call luarocks to download dependencies. Even the make is running in parallel, luarocks can't download in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6633: Adding -j parameter to the make.
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6633:
URL: https://github.com/apache/apisix/pull/6633#issuecomment-1072008971
as @spacewander said, this does not help with parallel downloads (it is not actually a make compilation process).
I will turn it off because there is no practical use for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org