You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "u70b3 (via GitHub)" <gi...@apache.org> on 2026/06/27 02:45:24 UTC
[PR] fix(writer): validate equality delete field ids [iceberg-rust]
u70b3 opened a new pull request, #2723:
URL: https://github.com/apache/iceberg-rust/pull/2723
## Which issue does this PR close?
- Closes #2722.
## What changes are included in this PR?
- Add writer config validation for equality delete field IDs.
- Reject empty equality ID lists, duplicate equality field IDs, and field IDs that are missing from the table schema.
- Keep the existing `RecordBatchProjector` behavior for unsupported field types and map/list reachability.
- Fix a stale comment: equality delete fields may be optional, unlike identifier fields.
## Are these changes tested?
- `cargo test -p iceberg test_equality_delete_rejects_empty_equality_ids --lib`
- `cargo test -p iceberg test_equality_delete_rejects_duplicate_equality_ids --lib`
- `cargo test -p iceberg test_equality_delete_rejects_missing_equality_id --lib`
- `cargo test -p iceberg test_equality_delete_unreachable_column --lib`
- `cargo test -p iceberg test_equality_delete_with_nullable_field --lib`
- `cargo test -p iceberg equality_delete --lib`
- `cargo fmt --check`
- `cargo test -p iceberg --lib`
- `cargo clippy -p iceberg --all-features --lib --tests -- -D warnings`
- `make check`
- `make unit-test`
Also attempted `make test`, but the local run did not reach tests because Docker image pull from Docker Hub timed out while starting `dev/docker-compose.yaml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(writer): validate equality delete field ids [iceberg-rust]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #2723:
URL: https://github.com/apache/iceberg-rust/pull/2723#issuecomment-4920696274
cc @CTTY @kevinjqliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(writer): validate equality delete field ids [iceberg-rust]
Posted by "u70b3 (via GitHub)" <gi...@apache.org>.
u70b3 commented on PR #2723:
URL: https://github.com/apache/iceberg-rust/pull/2723#issuecomment-4849868804
@viirya Thanks for the thorough and rigorous review — really appreciate you cross-checking the spec wording and the Java reference implementation.
You're right that the duplicate-id and schema-membership checks are deliberate stricter guards. A duplicate equality id is almost certainly a user/configuration error, and an id missing from the schema would lead to a confusing failure later (or a meaningless delete file). Failing fast here with a clear error message feels like the right behavior for the Rust writer.
I'll also open a corresponding PR against the Java SDK to add the same duplicate / missing-id validation there, so the two implementations stay aligned on this stricter behavior. I'll link it back to this PR once it's up.
Thanks again for the LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(writer): validate equality delete field ids [iceberg-rust]
Posted by "blackmwk (via GitHub)" <gi...@apache.org>.
blackmwk merged PR #2723:
URL: https://github.com/apache/iceberg-rust/pull/2723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org