You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/07/13 06:11:41 UTC
[GitHub] [servicecomb-service-center] little-cui opened a new pull request #1093: Change: Modify schema without considering service environment
little-cui opened a new pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Never comment source code, delete it.
- [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #1093: [SCB-2294]Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui commented on pull request #1093: [SCB-2294]Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
little-cui commented on pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#issuecomment-878847939
> 这个变更导致了服务端行为的变更,有一定隐患会造成配套客户端的不兼容。表现为:当用户原本注册微服务时,期望的是相同版本的微服务不覆盖契约,而现在变得可以覆盖了,继而引发我们无法想象的错误和失败。需要在RN中明确声明这次变更
已经录入RN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui commented on pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
little-cui commented on pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#issuecomment-878808067
#1090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668489820
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
我希望改的彻底些,既然都不兼容了,就全新设计配置项,默认就是false值,是最让人好理解的配置使用方式。schema.denyOverwriting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668489820
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
我希望改的彻底些,既然都不兼容了,就全新设计配置项,默认就是false值,是最让人好理解的配置使用方式。schema.notEditable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668489820
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
我希望改的彻底些,既然都不兼容了,就全新设计配置项,默认就是false值,是最让人好理解的配置使用方式。schemaOverwriting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668489820
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
我希望改的彻底些,用上这个配置的人肯定是期望可编辑,所以根本没必要保持配置项名字的兼容。既然默认行为都改变了,就全新设计配置项,默认就是false值,是最让人好理解的配置使用方式。schema.notEditable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668489820
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
我希望改的彻底些,用上这个配置的人肯定是期望契约可编辑,所以根本没必要保持配置项名字的兼容。既然默认行为都改变了,就全新设计配置项,默认就是false值,是最让人好理解的配置使用方式。schema.notEditable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang edited a comment on pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang edited a comment on pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#issuecomment-878835287
这个变更导致了服务端行为的变更,有一定隐患会造成配套客户端的不兼容。表现为:当用户原本注册微服务时,期望的是相同版本的微服务不覆盖契约,而现在变得可以覆盖了,继而引发我们无法想象的错误和失败。需要在RN中明确声明这次变更
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668489820
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
我希望改的彻底些,既然都不兼容了,就全新设计配置项,默认就是false值,是最让人好理解的配置使用方式。schema.overwriting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1093: [SCB-2294]Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#issuecomment-878870277
提供下配置项的配套文档说明
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668489820
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
我希望改的彻底些,既然都不兼容了,就全新设计配置项,默认就是false值,是最让人好理解的配置使用方式。schema.allowOverwriting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1093: [SCB-2294]Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
little-cui commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668506302
##########
File path: server/config/config.go
##########
@@ -170,7 +170,7 @@ func loadServerConfig() ServerConfig {
InstanceTTL: GetInt64("registry.instance.ttl", 0, WithENV("INSTANCE_TTL")),
SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")),
- SchemaEditable: GetBool("registry.schema.editable", false, WithENV("SCHEMA_EDITABLE")),
+ SchemaEditable: GetBool("registry.schema.editable", true, WithENV("SCHEMA_EDITABLE")),
Review comment:
DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#issuecomment-878835287
这个变更导致了服务端行为的变更,有一定隐患会造成配套客户端的不兼容。表现为:当用户原本注册微服务时,期望的是相同版本的微服务不覆盖契约,而现在变得可以覆盖了。需要在RN中明确声明这次变更
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668487111
##########
File path: datasource/etcd/ms.go
##########
@@ -45,6 +45,11 @@ import (
"github.com/apache/servicecomb-service-center/server/plugin/uuid"
)
+var (
+ ErrUndefinedSchemaID = pb.NewError(pb.ErrUndefinedSchemaID, datasource.ErrUndefinedSchemaID.Error())
+ ErrModifySchemaNotAllow = pb.NewError(pb.ErrModifySchemaNotAllow, datasource.ErrModifySchemaNotAllow.Error())
Review comment:
是否提供个简单的NewFromError的API更方便
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org