You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 04:56:36 UTC
[GitHub] [spark] viirya commented on a change in pull request #30332: [SPARK-33419][SQL] Unexpected behavior when using SET commands before a query in SparkSession.sql
viirya commented on a change in pull request #30332:
URL: https://github.com/apache/spark/pull/30332#discussion_r521839038
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
##########
@@ -71,6 +71,12 @@ object ParserUtils {
stream.getText(interval)
}
+ /** Get all the text which between the given start and end tokens. */
+ def interval(start: Token, end: Token): String = {
Review comment:
`interval` sounds not a good method name. Maybe `getTextBetweenTokens`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org