You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hhbyyh <gi...@git.apache.org> on 2017/03/13 18:26:56 UTC

[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

GitHub user hhbyyh opened a pull request:

    https://github.com/apache/spark/pull/17280

    [SPARK-19939] [ML] Add support for association rules in ML

    ## What changes were proposed in this pull request?
    jira: https://issues.apache.org/jira/browse/SPARK-19939
    Adding another essential characteristic for the Association Rule in Spark ml.fpm.
    
    Support is an indication of how frequently the itemset of an association rule appears in the database and suggests if the rules are generally applicable to the dateset. refer to [https://en.wikipedia.org/wiki/Association_rule_learning] for more details.
    
    Before adding support:
     rules | confidence 
    ---------|----------------
     beer -> soda | 0.5 
     pecan -> milk | 0.6 
    
    After adding support: 
     rules  | confidence | support 
    -------------------|----------------|-----------
     beer -> soda | 0.5 | 0.3 
     pecan -> milk | 0.6 | 0.01 
    
    Thus to allow a better understanding for the generated association rules. This is a new feature and was not included in the original function parity PR.
    
    ## How was this patch tested?
    
    existing and new unit test


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hhbyyh/spark arSupport

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17280
    
----
commit f86c5122eadd9b0a595b776d77d6cdf23ad6731a
Author: Yuhao Yang <yu...@intel.com>
Date:   2017-03-11T01:18:21Z

    half

commit bb8ed118619ae93badca06dc346304adce3fa4b7
Author: Yuhao Yang <yu...@intel.com>
Date:   2017-03-11T01:45:33Z

    Merge remote-tracking branch 'upstream/master' into arSupport

commit a0ad6628766a5bc556777629fddfc3c61d02d57a
Author: Yuhao Yang <yu...@intel.com>
Date:   2017-03-11T19:01:15Z

    Merge remote-tracking branch 'upstream/master' into arSupport

commit 9580aa910523144aba8e4f5a3d9693fe4387f16f
Author: Yuhao Yang <yu...@intel.com>
Date:   2017-03-12T17:50:30Z

    add support to association rules

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    I'll first focus on https://github.com/apache/spark/pull/17130 and resolve conflict here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #74458 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74458/testReport)** for PR 17280 at commit [`9580aa9`](https://github.com/apache/spark/commit/9580aa910523144aba8e4f5a3d9693fe4387f16f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1529/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #75715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75715/testReport)** for PR 17280 at commit [`3f780dc`](https://github.com/apache/spark/commit/3f780dca88d5b0460f91d552cf2e3ac4566fd929).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #92514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92514/testReport)** for PR 17280 at commit [`ce6959a`](https://github.com/apache/spark/commit/ce6959a88067e58a22aaea3e1592755766027d74).
     * This patch **fails MiMa tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #95318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95318/testReport)** for PR 17280 at commit [`733c7ff`](https://github.com/apache/spark/commit/733c7ff70c46f0c54cdf520b44645544b810e04e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #74610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74610/testReport)** for PR 17280 at commit [`1225496`](https://github.com/apache/spark/commit/1225496f3c00146ee45a99dcf19618a38d5d1462).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Thanks for taking a look @MLnick 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #95316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95316/testReport)** for PR 17280 at commit [`9e2854a`](https://github.com/apache/spark/commit/9e2854a9764b7f7a007d38c3ab89f2e228c0675e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2593/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #93842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93842/testReport)** for PR 17280 at commit [`34f883f`](https://github.com/apache/spark/commit/34f883f059efa9f857db6e707ef6507f1017fa63).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #74610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74610/testReport)** for PR 17280 at commit [`1225496`](https://github.com/apache/spark/commit/1225496f3c00146ee45a99dcf19618a38d5d1462).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93814/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #75715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75715/testReport)** for PR 17280 at commit [`3f780dc`](https://github.com/apache/spark/commit/3f780dca88d5b0460f91d552cf2e3ac4566fd929).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    I'll update this after FPGrowth examples and doc merged https://github.com/apache/spark/pull/17130, since there'll be some conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #92514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92514/testReport)** for PR 17280 at commit [`ce6959a`](https://github.com/apache/spark/commit/ce6959a88067e58a22aaea3e1592755766027d74).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1506/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77829/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95316/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17280#discussion_r125736603
  
    --- Diff: python/pyspark/ml/fpm.py ---
    @@ -186,29 +186,29 @@ class FPGrowth(JavaEstimator, HasItemsCol, HasPredictionCol,
         |[z]                     |
         |[x, z, y, r, q, t, p]   |
         +------------------------+
    -    >>> fp = FPGrowth(minSupport=0.2, minConfidence=0.7)
    +    >>> fp = FPGrowth(minSupport=0.4, minConfidence=0.7)
         >>> fpm = fp.fit(data)
         >>> fpm.freqItemsets.show(5)
    -    +---------+----+
    -    |    items|freq|
    -    +---------+----+
    -    |      [s]|   3|
    -    |   [s, x]|   3|
    -    |[s, x, z]|   2|
    -    |   [s, z]|   2|
    -    |      [r]|   3|
    -    +---------+----+
    +    +------+----+
    +    | items|freq|
    +    +------+----+
    +    |   [s]|   3|
    +    |[s, x]|   3|
    +    |   [r]|   3|
    +    |   [y]|   3|
    +    |[y, x]|   3|
    +    +------+----+
    --- End diff --
    
    set a higher minSupport to avoid the 0.3333333... in the support column.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #95318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95318/testReport)** for PR 17280 at commit [`733c7ff`](https://github.com/apache/spark/commit/733c7ff70c46f0c54cdf520b44645544b810e04e).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74458/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #78010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78010/testReport)** for PR 17280 at commit [`eb25f28`](https://github.com/apache/spark/commit/eb25f287393ccffeb1a5905f7752298808945a2c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #77829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77829/testReport)** for PR 17280 at commit [`180b43d`](https://github.com/apache/spark/commit/180b43df0cb1ca71f1bcabcae7dde933c5e301dc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17280#discussion_r161679593
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -319,9 +323,11 @@ object FPGrowthModel extends MLReadable[FPGrowthModel] {
     
         override def load(path: String): FPGrowthModel = {
           val metadata = DefaultParamsReader.loadMetadata(path, sc, className)
    +      implicit val format = DefaultFormats
    +      val numTrainingRecords = (metadata.metadata \ "numTrainingRecords").extract[Long]
    --- End diff --
    
    Does this break backward compatibility for loading?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75715/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #77829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77829/testReport)** for PR 17280 at commit [`180b43d`](https://github.com/apache/spark/commit/180b43df0cb1ca71f1bcabcae7dde933c5e301dc).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #78010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78010/testReport)** for PR 17280 at commit [`eb25f28`](https://github.com/apache/spark/commit/eb25f287393ccffeb1a5905f7752298808945a2c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78010/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17280#discussion_r161962624
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -319,9 +323,11 @@ object FPGrowthModel extends MLReadable[FPGrowthModel] {
     
         override def load(path: String): FPGrowthModel = {
           val metadata = DefaultParamsReader.loadMetadata(path, sc, className)
    +      implicit val format = DefaultFormats
    +      val numTrainingRecords = (metadata.metadata \ "numTrainingRecords").extract[Long]
    --- End diff --
    
    Yes it does now. If saving numTrainingRecords to FPGrowthModel looks good, I can update the load logic.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/610/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #93842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93842/testReport)** for PR 17280 at commit [`34f883f`](https://github.com/apache/spark/commit/34f883f059efa9f857db6e707ef6507f1017fa63).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92514/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #74458 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74458/testReport)** for PR 17280 at commit [`9580aa9`](https://github.com/apache/spark/commit/9580aa910523144aba8e4f5a3d9693fe4387f16f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17280#discussion_r125154331
  
    --- Diff: python/pyspark/ml/fpm.py ---
    @@ -186,29 +186,29 @@ class FPGrowth(JavaEstimator, HasItemsCol, HasPredictionCol,
         |[z]                     |
         |[x, z, y, r, q, t, p]   |
         +------------------------+
    -    >>> fp = FPGrowth(minSupport=0.2, minConfidence=0.7)
    +    >>> fp = FPGrowth(minSupport=0.4, minConfidence=0.7)
         >>> fpm = fp.fit(data)
         >>> fpm.freqItemsets.show(5)
    -    +---------+----+
    -    |    items|freq|
    -    +---------+----+
    -    |      [s]|   3|
    -    |   [s, x]|   3|
    -    |[s, x, z]|   2|
    -    |   [s, z]|   2|
    -    |      [r]|   3|
    -    +---------+----+
    +    +------+----+
    +    | items|freq|
    +    +------+----+
    +    |   [s]|   3|
    +    |[s, x]|   3|
    +    |   [r]|   3|
    +    |   [y]|   3|
    +    |[y, x]|   3|
    +    +------+----+
    --- End diff --
    
    this seems to change the result quite a bit, is this expected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #78005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78005/testReport)** for PR 17280 at commit [`eb25f28`](https://github.com/apache/spark/commit/eb25f287393ccffeb1a5905f7752298808945a2c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #95316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95316/testReport)** for PR 17280 at commit [`9e2854a`](https://github.com/apache/spark/commit/9e2854a9764b7f7a007d38c3ab89f2e228c0675e).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17280#discussion_r164942458
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -319,9 +323,11 @@ object FPGrowthModel extends MLReadable[FPGrowthModel] {
     
         override def load(path: String): FPGrowthModel = {
           val metadata = DefaultParamsReader.loadMetadata(path, sc, className)
    +      implicit val format = DefaultFormats
    +      val numTrainingRecords = (metadata.metadata \ "numTrainingRecords").extract[Long]
    --- End diff --
    
    Since we're adding numTrainingRecords to FPGrowthModel and there isn't a proper default number, I suggest we break the backward model loading compatibility. Otherwise we need to fill numTrainingRecords with an incorrect value and will likely create a maintenance trap.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #93814 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93814/testReport)** for PR 17280 at commit [`40cf449`](https://github.com/apache/spark/commit/40cf4497432bd4e2cbeec8e6647b52c4c8e74072).
     * This patch **fails Scala style tests**.
     * This patch **does not merge cleanly**.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74610/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95318/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Updated to support backward model loading compatibility. 
    @MLnick  @jkbradley 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    **[Test build #93814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93814/testReport)** for PR 17280 at commit [`40cf449`](https://github.com/apache/spark/commit/40cf4497432bd4e2cbeec8e6647b52c4c8e74072).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17280#discussion_r125154338
  
    --- Diff: python/pyspark/ml/fpm.py ---
    @@ -186,29 +186,29 @@ class FPGrowth(JavaEstimator, HasItemsCol, HasPredictionCol,
         |[z]                     |
         |[x, z, y, r, q, t, p]   |
         +------------------------+
    -    >>> fp = FPGrowth(minSupport=0.2, minConfidence=0.7)
    +    >>> fp = FPGrowth(minSupport=0.4, minConfidence=0.7)
         >>> fpm = fp.fit(data)
         >>> fpm.freqItemsets.show(5)
    -    +---------+----+
    -    |    items|freq|
    -    +---------+----+
    -    |      [s]|   3|
    -    |   [s, x]|   3|
    -    |[s, x, z]|   2|
    -    |   [s, z]|   2|
    -    |      [r]|   3|
    -    +---------+----+
    +    +------+----+
    +    | items|freq|
    +    +------+----+
    +    |   [s]|   3|
    +    |[s, x]|   3|
    +    |   [r]|   3|
    +    |   [y]|   3|
    +    |[y, x]|   3|
    +    +------+----+
    --- End diff --
    
    or rather, why is https://github.com/apache/spark/pull/17280/files#diff-b6dbf16870bd2cca9b4140df8aebd681L189 changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by hhbyyh <gi...@git.apache.org>.
Github user hhbyyh commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Please advice if this is a good feature to add. If not I'll close it. Thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93842/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17280: [SPARK-19939] [ML] Add support for association rules in ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17280
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2595/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org