You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2017/12/19 21:54:47 UTC
hbase git commit: HBASE-19556: Remove
TestAssignmentManager#testGoodSplit, which no longer make sense
Repository: hbase
Updated Branches:
refs/heads/branch-2 31ebd24b7 -> 1d7b0a995
HBASE-19556: Remove TestAssignmentManager#testGoodSplit, which no longer make sense
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1d7b0a99
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1d7b0a99
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1d7b0a99
Branch: refs/heads/branch-2
Commit: 1d7b0a99584992bab994ce6ef2f2a3e2dde76474
Parents: 31ebd24
Author: Yi Liang <ea...@gmail.com>
Authored: Tue Dec 19 11:31:44 2017 -0800
Committer: Michael Stack <st...@apache.org>
Committed: Tue Dec 19 13:53:37 2017 -0800
----------------------------------------------------------------------
.../assignment/TestAssignmentManager.java | 34 --------------------
1 file changed, 34 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/1d7b0a99/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
index 21f7ffb..f4365ea 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
@@ -169,36 +169,6 @@ public class TestAssignmentManager {
if (this.am.waitServerReportEvent(null, null)) throw new UnexpectedStateException();
}
- @Ignore @Test // TODO
- public void testGoodSplit() throws Exception {
- TableName tableName = TableName.valueOf(this.name.getMethodName());
- RegionInfo hri = RegionInfoBuilder.newBuilder(tableName)
- .setStartKey(Bytes.toBytes(0))
- .setEndKey(Bytes.toBytes(2))
- .setSplit(false)
- .setRegionId(0)
- .build();
- SplitTableRegionProcedure split =
- new SplitTableRegionProcedure(this.master.getMasterProcedureExecutor().getEnvironment(),
- hri, Bytes.toBytes(1));
- rsDispatcher.setMockRsExecutor(new GoodSplitExecutor());
- long st = System.currentTimeMillis();
- Thread t = new Thread() {
- public void run() {
- try {
- waitOnFuture(submitProcedure(split));
- } catch (Exception e) {
- e.printStackTrace();
- }
- }
- };
- t.start();
- t.join();
- long et = System.currentTimeMillis();
- float sec = ((et - st) / 1000.0f);
- LOG.info(String.format("[T] Splitting in %s", StringUtils.humanTimeDiff(et - st)));
- }
-
@Test
public void testAssignWithGoodExec() throws Exception {
// collect AM metrics before test
@@ -865,10 +835,6 @@ public class TestAssignmentManager {
}
}
- private class GoodSplitExecutor extends NoopRsExecutor {
-
- }
-
private void collectAssignmentManagerMetrics() {
assignSubmittedCount = assignProcMetrics.getSubmittedCounter().getCount();
assignFailedCount = assignProcMetrics.getFailedCounter().getCount();