You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/20 15:40:22 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #25175: Add datasets to dag dependencies view

dstandish commented on code in PR #25175:
URL: https://github.com/apache/airflow/pull/25175#discussion_r925763651


##########
airflow/models/dagbag.py:
##########
@@ -623,11 +623,12 @@ def _serialize_dag_capturing_errors(dag, session):
                 )
                 self.log.debug("Calling the DAG.bulk_sync_to_db method")
                 try:
+                    DAG.bulk_write_to_db(self.dags.values(), session=session)

Review Comment:
   yeah, the reason is, the datasets are written to DB in bulk_write_to_db.  we need the datasets to be in the DB so we can look up the ID when serializing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org