[GitHub] [spark] maropu commented on a change in pull request #29654: [WIP][SPARK-32802][SQL] Avoid using SpecificInternalRow in RunLengthEncoding#Encoder

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #29654:
URL: https://github.com/apache/spark/pull/29654#discussion_r485261889



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/compressionSchemes.scala
##########
@@ -182,29 +181,29 @@ private[columnar] case object RunLengthEncoding extends CompressionScheme {
     private var _uncompressedSize = 0
     private var _compressedSize = 0
 
-    // Using `MutableRow` to store the last value to avoid boxing/unboxing cost.
-    private val lastValue = new SpecificInternalRow(Seq(columnType.dataType))
+    private var lastValue: T#InternalType = _
     private var lastRun = 0
 
     override def uncompressedSize: Int = _uncompressedSize
 
     override def compressedSize: Int = _compressedSize
 
+

Review comment:
       nit: revert this unnecessary change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org