You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "malliaridis (via GitHub)" <gi...@apache.org> on 2024/09/18 13:13:17 UTC
[PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]
malliaridis opened a new pull request, #2717:
URL: https://github.com/apache/solr/pull/2717
https://issues.apache.org/jira/browse/SOLR-17457
# Description
On Windows the `bin/solr.cmd` uses the StatusTool with `--max-wait-secs`, but the flag is not supported in the new notation, only in the old format `-maxWaitSecs`.
# Solution
This PR adds support for the new notation, so that the `bin/solr.cmd` does not fail anymore when running `bin/solr.cmd start`.
Note that this change is not applicable to `main` because `maxWaitSecs` is already replaced in `StatusTool` with `max-wait-secs`.
# Tests
I have manually tested the changes on a Windows system, since I am not sure if we have any Windows-specific test bats.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh closed pull request #2717: SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd
URL: https://github.com/apache/solr/pull/2717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #2717:
URL: https://github.com/apache/solr/pull/2717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2717:
URL: https://github.com/apache/solr/pull/2717#issuecomment-2358712334
Clicked wrong button!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2717:
URL: https://github.com/apache/solr/pull/2717#issuecomment-2358711806
I just triggered the tests, and once they pass will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2717:
URL: https://github.com/apache/solr/pull/2717#issuecomment-2358936662
I ran the test that failed locally, and it looks great....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org