You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/06/19 07:12:09 UTC

[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7) 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13676

to review the following change.


Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)
......................................................................

KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

For whatever reason, some particular C++ syntax used in port.h caused
gcc 7 to crash with an internal error during compilation. This just
rephrases the code in a different way to avoid the issue.

Change-Id: Id95a4be07ff1e5ef60a95c65f5a850020f80a273
---
M src/kudu/gutil/port.h
1 file changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/13676/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id95a4be07ff1e5ef60a95c65f5a850020f80a273
Gerrit-Change-Number: 13676
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13676 )

Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95a4be07ff1e5ef60a95c65f5a850020f80a273
Gerrit-Change-Number: 13676
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 19 Jun 2019 15:56:42 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13676 )

Change subject: KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)
......................................................................

KUDU-2869. Fix compiler error with devtoolset-7 (gcc 7)

For whatever reason, some particular C++ syntax used in port.h caused
gcc 7 to crash with an internal error during compilation. This just
rephrases the code in a different way to avoid the issue.

Change-Id: Id95a4be07ff1e5ef60a95c65f5a850020f80a273
Reviewed-on: http://gerrit.cloudera.org:8080/13676
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/gutil/port.h
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id95a4be07ff1e5ef60a95c65f5a850020f80a273
Gerrit-Change-Number: 13676
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>