You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tupshin Harper (JIRA)" <ji...@apache.org> on 2012/09/28 14:24:08 UTC

[jira] [Created] (CASSANDRA-4731) Custom CQL transport needs to validate its framing

Tupshin Harper created CASSANDRA-4731:
-----------------------------------------

             Summary: Custom CQL transport needs to validate its framing
                 Key: CASSANDRA-4731
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4731
             Project: Cassandra
          Issue Type: Improvement
          Components: API
    Affects Versions: 1.2.0 beta 1
            Reporter: Tupshin Harper
            Assignee: Sylvain Lebresne


The current implementation of CASSANDRA-2478 does very little validation of its input. At a minimum, it should validate that the header bytes are all correct types, and validate that the frame as a whole doesn't exceed the max message length as specified in the header. As soon as it sees an invalid frame, it should return an error to the client and close the connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-4731) Custom CQL transport needs to validate its framing

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne resolved CASSANDRA-4731.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.0 rc1

I've made the binary protocol does that kind of validation and made it more resilient to client sending bad stuff in general in commit e27a9558737f4f0d18104fd57169f681bcfc1703.
                
> Custom CQL transport needs to validate its framing
> --------------------------------------------------
>
>                 Key: CASSANDRA-4731
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4731
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Tupshin Harper
>            Assignee: Sylvain Lebresne
>             Fix For: 1.2.0 rc1
>
>
> The current implementation of CASSANDRA-2478 does very little validation of its input. At a minimum, it should validate that the header bytes are all correct types, and validate that the frame as a whole doesn't exceed the max message length as specified in the header. As soon as it sees an invalid frame, it should return an error to the client and close the connection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira