[GitHub] [apisix-dashboard] membphis commented on a change in pull request #884: test: add route with valid remote_address (E2E)

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #884:
URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r531261060



##########
File path: api/test/e2e/route_with_valid_remote_addr_test.go
##########
@@ -44,14 +44,14 @@ func TestRoute_with_valid_remote_addr(t *testing.T) {
 			ExpectStatus: http.StatusOK,
 		},
 		{
-			caseDesc:     "verify route",
-			Object:       APISIXExpect(t),
-			Method:       http.MethodGet,
-			Path:         "/hello",
-			Headers:      map[string]string{"Authorization": token},
-			ExpectStatus: http.StatusOK,
-			ExpectBody:   "hello world",
-			Sleep:        sleepTime,
+			caseDesc: "verify route",
+			Object:   APISIXExpect(t),
+			Method:   http.MethodGet,
+			Path:     "/hello",
+			Headers:  map[string]string{"Authorization": token},
+			//ExpectStatus: http.StatusOK,

Review comment:
       why we need to delete this line?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org