You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jaikiran Pai <ja...@gmail.com> on 2015/01/20 17:06:27 UTC
Review Request 30078: Patch for KAFKA-1885
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1885
https://issues.apache.org/jira/browse/KAFKA-1885
Repository: kafka
Description
-------
KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
Diffs
-----
build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
Diff: https://reviews.apache.org/r/30078/diff/
Testing
-------
Thanks,
Jaikiran Pai
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69588
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Jan. 24, 2015, 11:52 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30078/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 11:52 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1885
> https://issues.apache.org/jira/browse/KAFKA-1885
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
>
>
> Diffs
> -----
>
> README.md 35e06b1cc6373f24ea6d405cccd4aacf0f458e0d
> build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
>
> Diff: https://reviews.apache.org/r/30078/diff/
>
>
> Testing
> -------
>
> Tested that existing support to run an entire individual test case from the command line works as advertised:
>
>
> ```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
>
> BUILD SUCCESSFUL
>
> ```
>
> Also tested that with this change it is now possible to run individual test methods as follows:
>
>
> ```
> ./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
>
> org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
> ```
>
>
> ```
> ./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
> ```
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69547
-----------------------------------------------------------
Ship it!
Ship It!
- Sriharsha Chintalapani
On Jan. 24, 2015, 11:52 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30078/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 11:52 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1885
> https://issues.apache.org/jira/browse/KAFKA-1885
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
>
>
> Diffs
> -----
>
> README.md 35e06b1cc6373f24ea6d405cccd4aacf0f458e0d
> build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
>
> Diff: https://reviews.apache.org/r/30078/diff/
>
>
> Testing
> -------
>
> Tested that existing support to run an entire individual test case from the command line works as advertised:
>
>
> ```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
>
> BUILD SUCCESSFUL
>
> ```
>
> Also tested that with this change it is now possible to run individual test methods as follows:
>
>
> ```
> ./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
>
> org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
> ```
>
>
> ```
> ./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
> ```
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/
-----------------------------------------------------------
(Updated Jan. 24, 2015, 11:52 a.m.)
Review request for kafka.
Bugs: KAFKA-1885
https://issues.apache.org/jira/browse/KAFKA-1885
Repository: kafka
Description
-------
KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
Diffs (updated)
-----
README.md 35e06b1cc6373f24ea6d405cccd4aacf0f458e0d
build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
Diff: https://reviews.apache.org/r/30078/diff/
Testing
-------
Tested that existing support to run an entire individual test case from the command line works as advertised:
```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
BUILD SUCCESSFUL
```
Also tested that with this change it is now possible to run individual test methods as follows:
```
./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
```
```
./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
```
Thanks,
Jaikiran Pai
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69532
-----------------------------------------------------------
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 24, 2015, 5:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30078/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 5:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1885
> https://issues.apache.org/jira/browse/KAFKA-1885
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
>
>
> Diffs
> -----
>
> build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
>
> Diff: https://reviews.apache.org/r/30078/diff/
>
>
> Testing
> -------
>
> Tested that existing support to run an entire individual test case from the command line works as advertised:
>
>
> ```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
>
> BUILD SUCCESSFUL
>
> ```
>
> Also tested that with this change it is now possible to run individual test methods as follows:
>
>
> ```
> ./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
>
> org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
> ```
>
>
> ```
> ./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
> ```
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69533
-----------------------------------------------------------
Ship it!
Non-Binding +1
- Manikumar Reddy O
On Jan. 24, 2015, 5:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30078/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 5:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1885
> https://issues.apache.org/jira/browse/KAFKA-1885
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
>
>
> Diffs
> -----
>
> build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
>
> Diff: https://reviews.apache.org/r/30078/diff/
>
>
> Testing
> -------
>
> Tested that existing support to run an entire individual test case from the command line works as advertised:
>
>
> ```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
>
> BUILD SUCCESSFUL
>
> ```
>
> Also tested that with this change it is now possible to run individual test methods as follows:
>
>
> ```
> ./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
>
> org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
> ```
>
>
> ```
> ./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
> ```
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Jaikiran Pai <ja...@gmail.com>.
> On Jan. 24, 2015, 7:05 a.m., Manikumar Reddy O wrote:
> > Can you update the README.md document
Sure. I just did and have updated this patch.
- Jaikiran
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69534
-----------------------------------------------------------
On Jan. 24, 2015, 11:52 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30078/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 11:52 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1885
> https://issues.apache.org/jira/browse/KAFKA-1885
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
>
>
> Diffs
> -----
>
> README.md 35e06b1cc6373f24ea6d405cccd4aacf0f458e0d
> build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
>
> Diff: https://reviews.apache.org/r/30078/diff/
>
>
> Testing
> -------
>
> Tested that existing support to run an entire individual test case from the command line works as advertised:
>
>
> ```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
>
> BUILD SUCCESSFUL
>
> ```
>
> Also tested that with this change it is now possible to run individual test methods as follows:
>
>
> ```
> ./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
>
> org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
> ```
>
>
> ```
> ./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
> ```
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69534
-----------------------------------------------------------
Can you update the README.md document
- Manikumar Reddy O
On Jan. 24, 2015, 5:13 a.m., Jaikiran Pai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30078/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 5:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1885
> https://issues.apache.org/jira/browse/KAFKA-1885
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
>
>
> Diffs
> -----
>
> build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
>
> Diff: https://reviews.apache.org/r/30078/diff/
>
>
> Testing
> -------
>
> Tested that existing support to run an entire individual test case from the command line works as advertised:
>
>
> ```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
>
> kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
>
> BUILD SUCCESSFUL
>
> ```
>
> Also tested that with this change it is now possible to run individual test methods as follows:
>
>
> ```
> ./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
>
> org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
> ```
>
>
> ```
> ./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
>
> kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
> ```
>
>
> Thanks,
>
> Jaikiran Pai
>
>
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/
-----------------------------------------------------------
(Updated Jan. 24, 2015, 5:13 a.m.)
Review request for kafka.
Bugs: KAFKA-1885
https://issues.apache.org/jira/browse/KAFKA-1885
Repository: kafka
Description
-------
KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
Diffs (updated)
-----
build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
Diff: https://reviews.apache.org/r/30078/diff/
Testing
-------
Tested that existing support to run an entire individual test case from the command line works as advertised:
```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
BUILD SUCCESSFUL
```
Also tested that with this change it is now possible to run individual test methods as follows:
```
./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
```
```
./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
```
Thanks,
Jaikiran Pai
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/
-----------------------------------------------------------
(Updated Jan. 20, 2015, 4:15 p.m.)
Review request for kafka.
Changes
-------
An attempt at better formatting the test run details
Bugs: KAFKA-1885
https://issues.apache.org/jira/browse/KAFKA-1885
Repository: kafka
Description
-------
KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
Diffs
-----
build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
Diff: https://reviews.apache.org/r/30078/diff/
Testing (updated)
-------
Tested that existing support to run an entire individual test case from the command line works as advertised:
```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
BUILD SUCCESSFUL
```
Also tested that with this change it is now possible to run individual test methods as follows:
```
./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
```
```
./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
```
Thanks,
Jaikiran Pai
Re: Review Request 30078: Patch for KAFKA-1885
Posted by Jaikiran Pai <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/
-----------------------------------------------------------
(Updated Jan. 20, 2015, 4:11 p.m.)
Review request for kafka.
Changes
-------
Added details about the tests done locally
Bugs: KAFKA-1885
https://issues.apache.org/jira/browse/KAFKA-1885
Repository: kafka
Description
-------
KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running individual test methods via gradle command line
Diffs
-----
build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
Diff: https://reviews.apache.org/r/30078/diff/
Testing (updated)
-------
Tested that existing support to run an entire individual test case from the command line works as advertised:
`./gradlew -Dtest.single=ProducerFailureHandlingTest core:test
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero PASSED
kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne PASSED
kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED
kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED
kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED
kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED
kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED
kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicasAfterBrokerShutdown PASSED
BUILD SUCCESSFUL
`
Also tested that with this change it's now possible to run individual test methods as follows:
`
./gradlew clients:test --tests org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime
org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime PASSED
`
`
./gradlew core:test --tests kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic PASSED
`
Thanks,
Jaikiran Pai